Nomifactory

Nomifactory

143k Downloads

Centrifuge is not properly applying base product chance for ashes recipe

SeuJurupenga opened this issue ยท 5 comments

commented

Pack Version:

bc5c6ba

Description:

The centrifuge is not properly producing the recipe involving ashes. The base product chance is not been respected, just overclocking the recipe.

Expected Behavior:
When placing ash in the centrifuge, the expected behavior is to produce small piles based on the base product chance. Using the GregTech OC Calculator, and putting the values for the ashes recipe, the expected is get the maximum base product chance at IV. Using a LuV Centrifuge (or higher tier), and 1 stack of ashes, shoud have as products: 1 stack of Small Pile of Phosphorus Pentoxide Dust, 1 stack of Small Pile of Soda Ash Dust, 1 stack of Small Pile of Magnesia Dust, 1 stack of Small Pile of Potash Dust and 2 stack of Small Pile of Quicklime Dust

Steps To Reproduce:
Using the centrifuge of any voltage and a power source, get some ashes, and put in centrifuge. The base product chance tier multiplier is ignored, just resulting in fast recipe with base product chance of a LV machine.

Crash Log:
There is no Crash Log

Screenshots:

2022-07-31_14 11 40
2022-07-31_14 11 44
2022-07-31_14 11 49
2022-07-31_14 11 57
2022-07-31_14 12 01
2022-07-31_14 12 06
2022-07-31_14 12 11
2022-07-31_14 12 15

commented

It's my first report on Github, so if I missed something I can edit it and provide more information.

commented

Unfortunately, the Ashes centrifuge recipe is not supposed to increase chances with overclocks, this is intentional. There's no easy way to update the tooltip to reflect this fact, as GTCE has to apply the same tooltip to all recipes.

commented

Normally in GTCE the tooltip reads X% + Y% per tier, as since v1.8.5 they use an additive bonus scaling system. Nomi pack balance was based on the v1.8.4 and older multiplicative scaling by tier, so we replace the overclocking function and the chance tooltip to just blanket read X%, doubles per tier everywhere.

This unfortunately does not clearly indicate the very rare exception where the tier bonuses are disabled. Ashes have always not scaled per tier (this is hard-coded in GTCE itself) because it would allow you to infinitely produce meaningful quantities of certain materials like phosphorus.

commented

Would it be possible to change the recipe in ContentTweaker or something to have tooltips corrected? Or are all GTCE recipes provided by GTCE and nothing else?

commented

The tooltip lang string cannot be overridden differently per recipe, only universally. This isn't something to do with CraftTweaker, it's a translation string override so that JEI shows a different tooltip than usual in its representation of a GTCE machine Recipe.