Rebirth of the Night (RotN)

Rebirth of the Night (RotN)

1M Downloads

[BUG] Typo detected in Horde's config that causes errors in logs (and presumably in gameplay) (READ for FIX!)

Ivan-Korpalo opened this issue ยท 2 comments

commented

Describe the bug

If you read through the logs: you will notice this series of errors:

[The Hordes]: Trying to read spawn table from config
[19:45:24] [Client thread/ERROR] [The Hordes]: Error adding entity minecraft:zombie-8-0-0{ArmorItems:[{},{},{},{id:"dungeontactics:studded_helmet",Count:1}],ArmorDropChances:[0f,0f,0f,0f],} null Entity
...
etc. I'm not gonna bore you with the rest

The cause of this is line 57 in "hordes.cfg"
minecraft:zombie-8-0-0{ArmorItems:[{},{},{},{id:"dungeontactics:studded_helmet",Count:1}],ArmorDropChances:[0f,0f,0f,0f],}

It is supposed to be:
minecraft:zombie{ArmorItems:[{},{},{},{id:"dungeontactics:studded_helmet",Count:1}],ArmorDropChances:[0f,0f,0f,0f],}-8-0-0

The parser cannot read the previous version and as a result, that specific zombie type isn't added to the possible horde spawns.
This same mistake is made in line 58 as well. The 3 numbers -8-0-0 are supposed to go after the NBT tags, not before them.

I've already corrected it in the config in my instance and tested it, I can verify this fix works.

To Reproduce

Boot up the game and wait for it to finish loading till you reach the main menu. Then close it. You don't even have to open a world. Then use ctrl-f to check the log file for the error message. It's present in all of my logs.

Expected behavior

The log should look like this:
[18:49:26] [Client thread/INFO] [The Hordes]: Trying to read spawn table from config
[18:49:26] [Client thread/INFO] [The Hordes]: Loaded entity minecraft:zombie{ArmorItems:[{},{},{},{id:"dungeontactics:studded_helmet",Count:1}],ArmorDropChances:[0f,0f,0f,0f],}-8-0-0 as net.minecraft.entity.monster.EntityZombie with weight 8, min day 0 and max day 0
[18:49:26] [Client thread/INFO] [The Hordes]: Loaded entity minecraft:zombie{ArmorItems:[{},{},{},{id:"ancientbeasts:desert_hood",Count:1}],ArmorDropChances:[0f,0f,0f,0f],}-8-0-0 as net.minecraft.entity.monster.EntityZombie with weight 8, min day 0 and max day 0

Screenshots

No response

Modpack Version

3.2

Server or singleplayer

Singleplayer

Version the world was created on:

3.2

Other...

No response

Additional context

No response

commented

After further research, it seems like the item "ancientbeasts:desert_hood" isn't in the game, so zombies spawned by that entry will just be bald. "dungeontactics:studded_helmet" is in the game though.

commented

Will take a look into this today