Rebirth of the Night (RotN)

Rebirth of the Night (RotN)

1M Downloads

[BUG] XP Dupe with Xorcite and Biotite

Oreo12 opened this issue · 20 comments

commented

Describe the bug

**

Right clicking Xorcite ore after mining biotite will give you an infinite amount of experience.
To Reproduce
Steps to reproduce the behavior:
Get to the end, find xorcite, wait for it to be fully matured, mine a single biotite ore, right click xorcite ore to your hearts content.
Expected behavior

Not sure lol

Info (please complete the following information):

  • Modpack Version: 2.77.5
  • Server or Singleplayer: Server
  • Version the world was created on: 2.77.5
commented

Can we confirm if this still happens in 3.0b5?

commented

Can we confirm if this still happens in 3.0b5?

Y e s.
image

commented

This still happens in v.3.0.1.
image

commented

This bug is still replicable as of version 3.1.1a.
image

commented

Update: The issue does not lie solely with End Reborn surprisingly enough.

  1. When mining a non-vanilla ore with a pickaxe, right clicking to harvest via Quark's feature will give experience as long as you continuously right click to harvest crops.
  2. Since the End Reborn End Flower and Xorcite ore both are considered "crops" with their growth stages, they yield experience infinitely due to this Quark vs modded blocks compatibility bug.
  3. Additionally, mining any spawner allows the player to acquire experience the same exact way except at a faster experience gain. (The experience gain per right click harvest scales with how much experience you acquire from mining a specific block)

I'm not sure if another mod is in play, but from what was tested, these two mods are the main culprits of the infinite experience glitch.

commented

This is definitely a very useful report, thanks kale! 🥬

commented

Haven’t tested this but it should work: Easily fixable in an afternoon for modpack purposes by turning off Quark’s auto-find-crops feature (quark.cfg line 1644) and finding/adding all crops in RotN to the list instead. Would also be much more versatile later. Of course finding and fixing the underlying bug is better, but in the interim….

commented

fuckin pain but i guess i got nothing better to do tonight

commented

Alternately we could turn off Quark's harvesting feature and add one of the standalone mods that does the same thing. Potentially those mods use a different form of detection that wouldn't cause this bug. And if it still occurs - then use my method posted above

commented

wait ok kilo you just made me realize something very genius- the glitch with harvesting crops giving you xp is probably caused by this same issue, albeit less abusable because its not infinitely "harvestable"

@democat3457 any way to fix this in quark?

commented

However, I could add a blacklist config to prevent certain crops from being right-click harvestable, or I could add a config option to only allow replanting of crops that have seeds (the xorcite cluster does not have seeds)

commented

Quark doesn't give xp directly, it must be inside Forge's calls to harvest the block. Also, the Simple Harvest mod works the exact same way in detection and firing (even down to the variable naming, I'm pretty sure the code was copied identically at some point), so using specifically that mod also wouldn't change anything.

commented

please do that

commented

to which, both?

commented

yeah, both

commented

Crops can no longer be right click harvested if they don’t specify a seed item, and for good measure, xorcite clusters have been added to the blacklist.

commented

Additionally, when mining end biotite and then heading home to right click harvest crops, you get exp per crop harvest for a certain amount of time.

commented

The mod update of 0.3.9 End Reborn mod did not fix the Xorcite giving infinite exp issue described above. [3.0 Beta 4]

commented

tbh end reborn has actually been really un-problematic recently

commented

unknown-96