[BUG] Dual-wielding causes damage buff effects to not work

Question

[BUG] Dual-wielding causes damage buff effects to not work

DorianZ2 opened this issue 3 years ago · 9 comments

DorianZ2 commented 3 years ago

Describe the bug

While dual-wielding melee weapons, the off-hand melee does half the damage and is unaffected by the damage buff effects such as Strength.

To Reproduce
Simply dual-wield any two weapons by grabbing one into your off-hand and try to attack something while paying attention to the damage numbers.

Expected behavior

the off-hand melee should do half the original weapon's damage, e.x. if the melee has 8 damage by default, the off-hand one will do only 4, even with Strength effect or other damage buffs, it will still be 4 damage.

Screenshots
Main hand viridium sword damage:

Off-hand viridium sword damage:

Info (please complete the following information):

Modpack Version:
- 2.77.5
- 3.0 BETA 5
- Other:
Server or Singleplayer:
- Server
- Singleplayer
Version the world was created on:
- 2.77.5
- 3.0 BETA 5
- Other:

Additional context

Nothing else to say.

bglandolt · Answer 1 · 2021-07-17T04:17:17.000Z

https://drive.google.com/file/d/1vBIT-IU3ST0G7Y2P_c_5jUBrOZDoxCfv/view?usp=sharing

lmk if this works for you, I made an update for the mod a few months ago

bglandolt · Answer 2 · 2021-07-17T06:20:21.000Z

rip, i always forget

https://drive.google.com/file/d/1vBIT-IU3ST0G7Y2P_c_5jUBrOZDoxCfv/view?usp=sharing

kil0byt3 · Answer 3 · 2021-07-17T06:18:02.000Z

https://drive.google.com/file/d/1vBIT-IU3ST0G7Y2P_c_5jUBrOZDoxCfv/view?usp=sharing

lmk if this works for you, I made an update for the mod a few months ago

Cool! However I don't have access:

@bglandolt

kil0byt3 · Answer 4 · 2021-07-17T06:24:55.000Z

Thanks - we'll test this

bglandolt · Answer 5 · 2021-07-17T06:37:00.000Z

Yeah I fixed: -the random crit chance -made it so weapon traits work for that weapon only, so a +30% damage (from quality tools) on your main hand weapon only affects your main hand (it affected offhand in the OG mod unfortunately) -made it so you can only swing with your offhand/main hand if you have the ‘energy’ for it -made it so warhammers penetrate the armor attribute (like the armor attribute that gets applied through rough mobs revamped) -other small tweaks, like making the warhammer rebuff work against mobs, or an option for adding extra damage to the dragbow (it does as much damage as a vanilla bow for some reason?) I haven’t touched the mod for a few months so idk if everything is working 100%, but yes let me know if that fixes your problem(s) :) Get Outlook for iOS<https://aka.ms/o0ukef>

democat3457 · Answer 6 · 2022-07-17T07:50:12.000Z

fairly sure this is solved by burgy fork

kil0byt3 · Answer 7 · 2021-06-03T20:28:56.000Z

as discussed, offhand 50% damage is intended as part of the mod/not a bug, but potion effects not working is a bug. Mod is abandoned so not sure if we can fix but we can try. https://www.curseforge.com/minecraft/mc-mods/better-combat-rebirth

KaleThyself · Answer 8 · 2021-06-03T23:06:02.000Z

as discussed, offhand 50% damage is intended as part of the mod/not a bug, but potion effects not working is a bug. Mod is abandoned so not sure if we can fix but we can try. https://www.curseforge.com/minecraft/mc-mods/better-combat-rebirth

In addition, this allows you to swing the weapon at a fixed rate, such as using the ender of worlds sword which has a very long charge up time in the main hand, but is nearly instantaneous to use in the offhand while stil providing the extinction enchantment effect.

democat3457 · Answer 9 · 2021-06-07T00:50:08.000Z

related to #62

Share to