Dynamic Lights [Data Pack]

Dynamic Lights [Data Pack]

Resource Packs
219k Downloads

Incompatible with Minecraft 1.21

rock3tsprocket opened this issue · 6 comments

commented

Describe the bug

everything lights up

Steps to reproduce

1: install the datapack in a world for 24w18a (idk if the mod also does that)
2: hold/drop anything

Expected behavior

for only the stuff listed in the readme to light up

Additional context

No response

commented

Thanks for the report. I will however first focus on compatibility for 1.20.5/1.20.6.

commented

Thanks for the report. I will however first focus on compatibility for 1.20.5/1.20.6.

1.20.6 made a huge change on JAVA from 17 to 21, and its release date is close to 24w18a, so It is a good idea that made the compatibility fix on 1.20.6 first.

commented

Well, the Java change isn't really that big of a deal, at least for this project. It's the new item components that make the pack incompatible.

commented

Did fixing it for 1.20.6 automagically fix it for 1.21?

commented

It definitely helped, but some parts are for sure not compatible with the latest snapshot yet

commented
Why have you only started updating now?

My last exam for this semester was on 07/03/2024. I hope it's understandable that I focused on my exam phase first.

Support for Snapshot 24w18a was added with this commit (forgot to link): 2ea659d
Temporary dev builds for this commit are available here (you need to sign in to be able to download)

Support for Snapshot 24w21a was added with this commit: 6a600f9
Temporary dev builds for this commit are available here

Final changes for 1.21 support were added with 96a4df7 and 275613d
Temporary dev builds are available here
Please report any bugs that might have crept in.

  • 🎉2