Dynamic Lights [Data Pack]

Dynamic Lights [Data Pack]

219k Downloads

In 1.20 pre1 / RC1 no light emiting from Hand/Armour

WarLord211 opened this issue ยท 6 comments

commented

Describe the bug

With the new 1.20 pre releases the Torches emit no light when in Hand.
On the Ground they Do.

Also the enchanted shield emits no light.

in 1.19.4 everything is fine

Steps to reproduce

get 1.20 pre1 and load the datapack

Expected behavior

No response

Additional context

No response

commented

Thanks for the bug report. This happened because Mojang decided to rename the key word alternative to any_of used in predicates in Snapshot 23w18a.
I'm currently trying to find a way for maintaining backwards compatibility, but an easy fix for a version that only works in 1.20 or above would be to rename any occurrences of minecraft:alternative to minecraft:any_of in all JSON files located in ../data/dynamiclights/predicates/.

commented

the renaming fixed it for me.
THX

commented

Hi with the 1.20 Release Candidate 1
It stopped again working.

Standart version and with the modifikation you mentioned before

commented

That's weird, there is nothing stated in the game changelogs that changed anything significant. I'll have to take a closer look at it

commented

I found a way to not use the alternative or any_of keyword at all inside the predicates and managed to maintain backwards compatibility down to Minecraft 1.17 with the latest commit. Let me know if you experience any other issues with it ๐ŸŽ‰

commented

tested the master and it works nice :)
Thx for the quick fix