Untranslatable strings
NeunEinser opened this issue ยท 7 comments
- [player] joined [color] team
- Pregen chat messages ("Preparing Spawm...", "Loading Terrain")
Oh, I've found the More setting coming soon
sign in code:
My suggestion for change:
Add translation for each
team display name
like (example for blue):
"bingo.team_name.blue" : "Blue Team"
Add translation for
team joining
:
"bingo.lobby.team_join" : "%s joined the %s"
I think I'd prefer a separate string for each team join message (e.g. %s joined the blue team.
). Usually stuff like this is better for languages were words change depending on context, so I like to stick to more specific strings as much as possible.
*also - the title of the issue should be "Untranslated strings", cause they ARE translatable ;)
Not sure how you mean it, but no they are not translatable. It is impossible to change them through language json files. An untranslated string would be a string missing from e.g. de_de.json
(but present in en_us.json
).
Oh, I've found the
More setting coming soon
sign in code:
Yeah not sure about this one. I originally planned to implement them before a 5.0 full release, so this sign was never meant to be there for long. But I guess by now it'd make sense to add that as well.
Ok, now I see what you meant here - that we cannot translate them to other languages, cause they are hardcoded
right now
And previously I understood the untranslatable as those, which we cannot even translate through lang-identifiers
I fail to see the difference between the two statements. You cannot translate them through lang identifiers, that is true for these hardcoded texts - because they are hardcoded ๐
I think I'd prefer a separate string for each team join message (...) this is better for languages were words change depending on context
Oh yeah sure
It is impossible to change them through language json files. An untranslated string would be a string missing from e.g. de_de.json (but present in en_us.json).
Ok, now I see what you meant here - that we cannot translate them to other languages, cause they are hardcoded right now
And previously I understood the untranslatable as those, which we cannot even translate through lang-identifiers
Also, that's probably the best RegEx
for search stripping to search for tellraw
command that doesn't use translate
(assuming that entire command is translatable correctly when translate
is used):
The RegEx: /tellraw(?!.*translate).*/
Summarizing - lines with hardcoded
text, that should be translatable (added to lang-files):
- "Preparing spawn..."
- "Loading terrain"
- "GO!"
-
sign
: "More setting coming soon..." +click_events
- "[ERROR] Could not find categories [...] of item [...]"
Team joining
Currently in command blocks (behind team-selection-button-wall):
tellraw @a ["", {"selector": "@p"}, " joined the blue team"]
My suggestion for change:
- Add translation for each
team display name
like (example for blue):
"bingo.team_name.blue" : "Blue Team"
- Add translation for
team joining
:
"bingo.lobby.team_join" : "%s joined the %s"
- Update command blocks with (example for blue):
tellraw @a {"translate":"bingo.lobby.team_join","with":[{"selector":"@p"},{"translate":"bingo.team_name.blue"}]}
*can add additional coloring for the team name:
tellraw @a {"translate":"bingo.lobby.team_join","with":[{"selector":"@p"},{"translate":"bingo.team_name.blue","color":"blue"}]}
Pregen messages
Add translations for those lines:
*also - the title of the issue should be "Untranslated strings", cause they ARE translatable ;)
One more untranslated text: