Saturation Effect is flickering in inventory while in lobby
RedstoneDubstep opened this issue ยท 5 comments
Since Bingo 5.0 Pre-Release 1, there is a flickering Saturation effect in the survival/adventure mode inventory while the player is in the lobby. This flickering can be irritating for some players when navigating in their inventory, and should thus be prevented, e.g. by increasing the amount of time the effect is active for.
Attached is an example of the flickering Saturation effect.
2022-01-04_15.mp4
This was really confusing, since the time you specify for effects is usually in seconds, so 1 second should never cause such flickering.
But then there is https://bugs.mojang.com/browse/MC-19648 :D
Suggestion - Just like during the game start:
- Here (in skybox) are given permanent effects:
bingo/data/bingo/functions/game/start/spawn_players.mcfunction
Lines 18 to 21 in ab81d8a
- Than here (after the countdown) they are cleared:
... it can be also changed here 1
-> 1000000
for effect to last for **:**
(aka permanent; +without digits flickering):
bingo/data/bingo/functions/lobby/player_tick.mcfunction
Lines 8 to 9 in ab81d8a
... it can be also changed here
1
->1000000
for effect to last for**:**
Note that even with permanent effect, you won't need to clear the effect until next game starts (which is already done after countdown) ๐
Either all effects are temporary or all effects are "permanent". The levitation effect in the same file can't be permanent without additional clear commands.
I also don't like it from a programming point of view, as the end of the countdown is not really related to leaving the lobby.