Fetchr

Fetchr

556 Downloads

Make the resource pack check version-specific

NeunEinser opened this issue ยท 5 comments

commented

If someone uses the resource pack from a previous version, the resource pack check will falsely assume the player has the resource pack installed correctly, breaking some things.

commented

My suggestion:

  • language placeholder string:
    encode additional version data in lang placeholder string?
    eg. bingo_5.0pre1/bingo5.0pre1 (currently just bingo)
  • DoNotTranslateThis entity (Single Player auto-resourcepack-detection):
    • (A) force manual check - remove following line
      execute if score $is_multiplayer bingo.state matches 0 run scoreboard players set @a[tag=bingo.resourcepack_check] bingo.resources 91
    • (B) add version data to DoNotTranslateThis -> DoNotTranslateThis_5.0pre1/DoNotTranslateThis_bingo5.0pre1
commented

I'd probably just go for an incremental number (so start at 1, then 2 and so on).
Singleplayer difference is supposed to stay. It doesn't really matter that much for SP as the resourcepack is automatically applied through the world download, but Ig it doesn't hurt either.

commented

To elaborate a bit more, I actually wanted to make a separate technical string for this.

  • %1074992263$s%1$s stays as is.
  • Add another string like %1074992263$s%3$s%1$s which is checked 2nd. This way we can have 2 error messages, one for "you do not have the rp" and one for "you have the wrong version of the rp". %3$s is the version indicator in this case, I think 3 is the first number that's save to use. It's simpler to modify for future versions if it's not included in the encoded string
  • Remove technical strings from language files other than en_us, so you only have to edit one file.

It should be sufficient to keep one DoNotTranslateThis string though, as it's only used for checking whether the player should be teleported immediately, so having the logic in the chat message should be sufficient.

commented

(...) Singleplayer difference is supposed to stay. It doesn't really matter that much for SP as the resourcepack is automatically applied through the world download, but Ig it doesn't hurt either.

Right, DoNotTranslateThis can stay as it is

commented

I guess the resourcepack-version check is just needed for release versions, so won't add it (for now) in the message with

This is not a release version (...)

Also, won't add the version check to the sign, cause it would add another place to update the version ID(iteraction)
and it activates the check-message anyway.