Fetchr

Fetchr

556 Downloads

[ResourcePack check] Make version-check message translatable

Kri5t0fK opened this issue ยท 1 comments

commented

Hmm, thinking about this it would actually kind of cool to have this text translatable in future versions. Might need some more thought and not necessarily needed as part of this pr, but I think it should be possible like this:

  • Add another translation string that has the meaning of "v3 or above" which all future versions will include. I am not sure about the pattern to use here, maybe just encode a _up into the namespace, or simply add another %3$s which just gets the definition of "or above".
  • If v3 or higher use translatable string
  • Otherwise fall back to hardcoded string

For this pr it would only be needed to include the translatable string in the lang file, as it obviously will never be used in the next release, only the one after this one. But ofc doesn't hurt to include it as well, especially for testing.

Originally posted by @NeunEinser in #111 (comment)

commented

Use translatability-check in the sign:

From #108

I guess the resourcepack-version check is just needed for release versions, so won't add it (for now) in the message with

This is not a release version (...)

Also, won't add the version check to the sign, cause it would add another place to update the version ID(iteraction) and it activates the check-message anyway.

Hmm, not sure I like having this text when the resource pack is not correctly installed

"bingo.resourcepack_check.sign.line1": "Resource pack",
"bingo.resourcepack_check.sign.line2": "was installed.",
"bingo.resourcepack_check.sign.line3": "Click here for",
"bingo.resourcepack_check.sign.line4": "chat message.",

I think the default "Download resource pack" is fine though (perhaps with a translatable version if greater equal v3 is enabled, like suggested in above), so that would include one more place, but since this can be done with a simple search replace I am not too worried. I might want look into a release script anyways, I have some ideas for that.

Originally posted by @NeunEinser in #111 (comment)