(5.1.2-pre1 on 1.20.4)

Twice during Phedran's stream today we used the "points race" mode, and both times it announced the wrong winner?

And for completeness, it was 3 teams of 1 player each.

Screenshots are from my own POV recording. I was on Orange team.

Game today with 5 teams of 1 player each.

Second place was announced as the winner.

I wonder if this is an off-by-1 error, like referencing [1] instead of [0] somewhere.

Second game got it right lol

Yeah, im pretty sure it's arbitrary. fetchr:item_detection/goals/points/find_winners is supposed to iterate over a temporary copy of the teams array, but in the calling function that temporary array is never actually copied/created.

So, I think it just grabs some garbage data from whatever team happens to have been operated on last.

I haven't had time to check if this fixes it, and it doesn't happen in singleplayer, but I think I might have ways to reproduce it still.

Will test and provide feedback, pending next hosted multiplayer session with Phedran and her patrons.

Three more rounds tonight with Phedran's patrons. Correct winner(s) selected every time. I consider this fixed.