Content Patcher

Content Patcher

463k Downloads

[Content Patcher] marriage dialogue not invalidated correctly

Pathoschild opened this issue ยท 2 comments

commented

If a marriage dialogue patch doesn't apply until a subsequent day, it's not applied when the conditions match (see sample log).

Repro steps:

  1. Add this save file and this content pack.
  2. Go to bed in-game.
  3. patch summary shows the dialogue is loaded and conditions match, but not applied.

Reported by tenthousandcats#0967.

commented

That's difficult to fix. The marriage dialogue is set in npc.dayUpdate and npc.marriageDuties from the middle of _newDayAfterFade, so Content Patcher can't just update its context before it's called or invoke a reload-dialogue method. Not sure how to fix this cleanly yet (without just reimplementing the game logic).

commented

Fixed via Stardew Valley 1.4 and the upcoming SMAPI 3.2.