SMAPI - Stardew Modding API

SMAPI - Stardew Modding API

971k Downloads

Remove IConfigFile support

Pathoschild opened this issue ยท 2 comments

commented

SMAPI has an IConfigFile interface which gives mods more control over their model read/writing and adds config.Reload() and config.Save() methods to the model. This was meant as a compromise between the old system (with a model that did all the work) and the new system (with a POCO model). See #159 for discussion at the time.

I propose removing it for the following reasons:

  • To my knowledge, nobody has ever used this interface.
  • It detracts from the intended SMAPI design, in which crosscutting concerns like serialisation and config format are encapsulated for mods.
  • It unnecessarily complicates the code, since we need to intercept deserialisation.
  • Mods that need more control over serialisation use Json.NET directly anyway.

Any objections to removing it?

commented

Deprecated in SMAPI 1.9, to be removed in 2.0.

commented

This is now removed in SMAPI 1.9, since it seems to be unused.