API instance can't be non-public

Question

API instance can't be non-public

spacechase0 opened this issue 7 years ago · 5 comments

spacechase0 commented 7 years ago

Pathoschild · Answer 1 · 2018-02-16T04:07:23.000Z

Fixed in develop for the upcoming SMAPI 2.5. The error happened because your API is marked internal, so SMAPI's proxy class couldn't access it. SMAPI will now rewrite all mod DLLs to inject an [InternalsVisibleTo("StardewModdingAPI.Proxies")] attribute.

Pathoschild · Answer 2 · 2018-02-17T21:40:04.000Z

I reverted the previous fix since that would break debugging support.

Pathoschild · Answer 3 · 2018-02-17T23:26:12.000Z

I played around with using DynamicMethod to bypass visibility checks in the IL-generated proxy class, but I'm shelving this for now. Instead I'll mark it a known issue and validate that the target type is public until we can address this.

TehPers · Answer 4 · 2018-05-25T06:09:03.000Z

I wonder if it's possible to emit a proxy class for the API into the mod's assembly at runtime that's marked as public?

Pathoschild · Answer 5 · 2019-12-22T18:13:23.000Z

This ticket is stale, I have no plans to add support for internal classes in the near future, and it's documented as a requirement for exposing an API. A pull request is welcome if someone wants to contribute an implementation though.

Share to