Intermittent rewrite errors with parallel rewriting enabled

Question

Pathoschild opened this issue 5 years ago · 2 comments

Pathoschild commented 5 years ago

When you enable RewriteInParallel in smapi-internal/config.json, SMAPI sometimes throws errors during mod assembly rewriting.

Sample logs:

date	summary
2020-06-11	`NullReferenceException` in `AssemblyLoader.Dispose()`.
2020-06-19	`NullReferenceException` in `BaseInstructionHandler.MarkFlag` on `this.Flags` (which is never null).
2020-06-28	`NullReferenceException` in `AssemblyLoader.Dispose()`.

spacechase0 · Answer 1 · 2020-08-16T03:49:31.000Z

Should this be closed since you removed the relevant code in 544919a ?

Pathoschild · Answer 2 · 2020-08-16T05:57:36.000Z

Yep. Thanks!