smapi won't run when running inside linux sandbox ( firejail )
kuesji opened this issue ยท 3 comments
describe the bug
you are adding unnecessary things to game/StardewValley file like checking user's terminal. this is breaking game launch in strict sandbox environments where launching new terminal is prohibited but executing sandboxed binaries allowed.
to reproduce
- install firejail
- create directory named stardew_valley
- install game into stardew_valley
- launch firejail with default profile via
firejail --private=stardew_valley
- launch game with
./GOG_Games/StardewValley/start.sh
- game wont run due can't launch gnome-terminal
solution:
remove terminal detection and just use
export TERM=xterm
exec $LAUNCHER $@
Hi! The simplicity would be nice, but SMAPI looks for a preferred terminal first because there were often issues with terminals that didn't work with the game's bundled version of Mono (e.g. see #219, #227, #489, #656, and #676). Now that it's fully working for the vast majority of Linux users, I'm wary of potentially rebreaking it for many users.
Thanks! Fixed via #776 for the upcoming SMAPI 3.10.