SMAPI - Stardew Modding API

SMAPI - Stardew Modding API

2M Downloads

Blocked jsdelivr breaks smapi.io/mods with no user-friendly error message

PimpOfSune opened this issue ยท 1 comments

commented
STOP!

Is this a specific development task? Don't create an issue if not!
See https://smapi.io/community if something isn't working, you have questions or ideas, or you want
to discuss something.

If you're absolutely sure it's a specific development task (e.g. a specific bug, not just
'something went wrong on my computer'), edit the template below.

I'm keeping the text from template above for context.

Give me some place fitting for reporting technical issues related to https://smapi.io/mods source code - and I sure will do this.
Paging through https://github.com/Pathoschild?tab=repositories led to nothing.
There are no links at smapi.io itself.
https://github.com/Pathoschild/SmapiCompatibilityList don't have Issue reporting tab for us plebs.
So... d'oh...

Discord have completely failed me as a tool for convenient communication so please let's resort to critically acclaimed source code host with evenly critically acclaimed issue reporting tool built in just fine, okie?

Describe the bug
Whole https://smapi.io/mods becomes defunct with 0 feedback about the cause to end user, if something impedes JS bundles loading.

To Reproduce
Easy way in our lands:

Live in some place where jsdelivr.net or its sub-domains are banned at ISP level.
Try to open https://smapi.io/mods .
See defunct page with 0 error messages on page and some marginally related errors in console / network debugging tools.
Image

Log file
I'm not quite in the mood for a logging proper. After all, I've left IT and descended into retail to actually have some rest from infinite bug reports and endless "bug or feature or not our problem" quarreling.
In my specific case it boils down to our ISP servicing counterfeit certificate instead of cdn.jsdelivr.net , which fails web browser's security checkup for your chosen CDN solution on attempt to open mod compatibility table (because everyone's beloved Chromium knows better and don't seem to give options to whitelist specific domains anymore), which results in JS bundles not being serviced.
Whatever means are utilized in other countries, the result is supposed to be the same.
Other pages under smapi.io domain do not seem to be affected.

Screenshots
I'd write a usual pair of ER and AR instead, as per my old IT habit.

Actual result:
No JS bundles loaded.
The page is unisable.
The page is full of placeholders.
Errors in console point at certificate problem <- relevant for my specific case, will show other things if reproduced by other means

Expected result 1:
Some user friendly error message and an instruction describing steps needed to either get help or make one of the best mod listings / compatibility charts of all time (<- not an exaggeration. I wish we had tool like this for Skyrim) usable again right away

Expected result 2:
If, for some reason, CDN fails - some other solution endures. Whatever works to fetch JS if primary delivery has failed, works.

Sincerely,
Aliaksandr

commented

Paging through https://github.com/Pathoschild?tab=repositories led to nothing.

This repo is correct; the web code is in src/SMAPI.Web.

Live in some place where jsdelivr.net or its sub-domains are banned at ISP level.
Try to open https://smapi.io/mods .
See defunct page [...]

Fixed; all third-party libraries are now served from smapi.io instead of external CDNs. Thanks for reporting it!