Handle macro renames
nfet opened this issue ยท 1 comments
Enhancment
Common Macros renamed outside the character utilizing ActionbarPlus could potentially be renamed and disappear in the action buttons.
Background
An UPDATE_MACROS event is fired whenever a macro is created, updated. ActionbarPlus can handle these events if enabled. If another character on the same amount updates a macro, the other character referencing the same macro in ActionbarPlus buttons is not aware of it and potentially will lose the reference to the macro.
Option 1
Make a deep copy of the macros being used in ActionbarPlus
Pros
- The macro will be unaffected of outside changes
Cons
- Duplicate copy of macro code
- User would have to drag and drop the newly update macro again to ActionbarPlus.
Option 2
Make the best possible guess of which macro to bind to when changes occurred, i.e. macro ID, name or body that exist in ActionbarPlus has to match what's in Blizzard's macro UI.
Solution
Fix is to keep the Macro UI as the golden record and sync macros between ActionbarPlus and Macro UI (Option 2 above)
Fixed in 1.0.0.17-beta; See 1.0.0.19-beta