Legendary Rings don't show a border.

Please try the following user rule for the time being:

return {
    -- The Savage Hollows, DPS only
    BuffAliases {
        {
            "item:124634", -- Thorasus, the Stone Heart of Draenor
            "item:124635", -- Nithramus, the All-Seer
            "item:124636", -- Maalus, the Blood Drinker
        },
        {
            187616, -- Nithramus
            187619, -- Thorasus
            187620, -- Maalus
        }
    },
    -- Tanks only
    BuffAliases {
        "item:124637", -- Sanctus, Sigil of the Unbroken
        187617, -- Sanctus
    },
    -- Heal only
    BuffAliases {
        "item:124638", -- Etheralus, the Eternal Reward
        187618, -- Etheralus
    },
}

Feedback whether it works is very welcome since I can't confirm this on any of my characters currently.

I’m only able to test Maalus, but it didn’t seem to work, no border.

From: Rainrider [mailto:[email protected]]
Sent: 5. august 2015 23:21
To: Adirelle/AdiButtonAuras [email protected]
Cc: tordenflesk [email protected]
Subject: Re: [AdiButtonAuras] Legendary Rings don't show a border (#189)

Please try the following user rule for the time being:

return {
-- The Savage Hollows, DPS only
BuffAliases {
{
"item:124634", -- Thorasus, the Stone Heart of Draenor
"item:124635", -- Nithramus, the All-Seer
"item:124636", -- Maalus, the Blood Drinker
},
{
187616, -- Nithramus
187619, -- Thorasus
187620, -- Maalus
}
},
-- Tanks only
BuffAliases {
"item:124637", -- Sanctus, Sigil of the Unbroken
187617, -- Sanctus
},
-- Heal only
BuffAliases {
"item:124638", -- Etheralus, the Eternal Reward
187618, -- Etheralus
},
}

—
Reply to this email directly or view it on GitHub https://github.com/Adirelle/AdiButtonAuras/issues/189#issuecomment-128152428 . https://github.com/notifications/beacon/ACCal6LtMc3FNTObGGtDWTednB39hOHqks5oknWqgaJpZM4Fj8iU.gif

No, I didn’t. Looks to be working now. Thank you :)

From: Rainrider [mailto:[email protected]]
Sent: 6. august 2015 12:26
To: Adirelle/AdiButtonAuras [email protected]
Cc: tordenflesk [email protected]
Subject: Re: [AdiButtonAuras] Legendary Rings don't show a border (#189)

Did you reload the ui after adding the user rule? Can you confirm the that the ring on your action bars is green after you click on "Spells & Items" in ABA's config.

The expected behavior is to have a green border and a timer for the buff duration.

Could you also verify the id of the buff when it is active as well as the item id of the ring?

—
Reply to this email directly or view it on GitHub https://github.com/Adirelle/AdiButtonAuras/issues/189#issuecomment-128318289 . https://github.com/notifications/beacon/ACCal2GefUAuOxUw74sQxXh5EoH7iM8Fks5oky3UgaJpZM4Fj8iU.gif

Did you reload the ui after adding the user rule? Can you confirm the that the ring on your action bars is green after you click on "Spells & Items" in ABA's config.

The expected behavior is to have a green border and a timer for the buff duration.

Could you also verify the id of the buff when it is active as well as the item id of the ring?

I added this to the wiki for future reference.

I'm closing the issue since LibItemBuffs has to be updated and this case along others should be handled there. The user rule is the solution for the time being.

As LibItemBuffs only handle enchantments, trinkets and consummables, a new handler should be added for these items. As these items are quite exceptional, I suggest adding the rules in ABA default rules.

Ok, I will add those later today

On Fri, Aug 7, 2015, 11:36 Guillaume Perréal [email protected]
wrote:

As LibItemBuffs only handle enchantments, trinkets and consummables, a new
handler should be added for these items. As these items are quite
exceptional, I suggest adding the rules in ABA default rules.

—
Reply to this email directly or view it on GitHub
https://github.com/Adirelle/AdiButtonAuras/issues/189#issuecomment-128656539
.

Just tagged a release on wowace, which includes the changes. You can safely remove the user rule

I’ve had a chance to test it in a raid setting where someone else (one of our melee) has the responsibility of using it.

It obviously doesn’t show then.

Will try the new version and see during our next raid if I can provide you with more info if you’d like.

From: Rainrider [mailto:[email protected]]
Sent: 7. august 2015 20:00
To: Adirelle/AdiButtonAuras [email protected]
Cc: tordenflesk [email protected]
Subject: Re: [AdiButtonAuras] Legendary Rings don't show a border (#189)

Just tagged a release on wowace, which includes the changes. You can safely remove the user rule

—
Reply to this email directly or view it on GitHub https://github.com/Adirelle/AdiButtonAuras/issues/189#issuecomment-128779152 . https://github.com/notifications/beacon/ACCal-HMemZ9gTLOY-sMt5bd2LMYSNP7ks5olOmQgaJpZM4Fj8iU.gif

The new version won't work too. The rule I used (BuffAliases) would only cover buffs cast by the player. That is my fault. I'll fix it later today or tommorow, sorry about that.

Please confirm it works now. The new version should be up on wowace in some minutes.

Yup, works now. Doesn’t show a countdown for the buff though.

Mvh.

Esben

From: Rainrider [mailto:[email protected]]
Sent: 9. august 2015 17:36
To: Adirelle/AdiButtonAuras [email protected]
Cc: tordenflesk [email protected]
Subject: Re: [AdiButtonAuras] Legendary Rings don't show a border (#189)

Please confirm it works now. The new version should be up on wowace in some minutes.

—
Reply to this email directly or view it on GitHub https://github.com/Adirelle/AdiButtonAuras/issues/189#issuecomment-129199363 . https://github.com/notifications/beacon/ACCaly5yV_ZNdkdB8WZRfXGNCR_mFbz4ks5ol2rRgaJpZM4Fj8iU.gif

It should display the expiration timer. Please check your settings.

When I use it, it shows:

When someone else uses it it doesn’t:

Mvh.

Esben

From: Rainrider [mailto:[email protected]]
Sent: 13. august 2015 17:29
To: Adirelle/AdiButtonAuras [email protected]
Cc: tordenflesk [email protected]
Subject: Re: [AdiButtonAuras] Legendary Rings don't show a border (#189)

It should display the expiration timer. Please check your settings.

—
Reply to this email directly or https://github.com/Adirelle/AdiButtonAuras/issues/189#issuecomment-130729678 view it on GitHub.

Does the buff you get when someone else used the trinket ring have a duration in the default ui?

And just to be sure I understood you correctly: the green border appears in every case but the expiration timer only when you used the ring?

yup

Mvh.

Esben

From: Rainrider [mailto:[email protected]]
Sent: 15. august 2015 15:49
To: Adirelle/AdiButtonAuras [email protected]
Cc: tordenflesk [email protected]
Subject: Re: [AdiButtonAuras] Legendary Rings don't show a border (#189)

And just to be sure I understood you correctly: the green border appears in every case but the expiration timer only when you used the ring?

—
Reply to this email directly or view it on GitHub https://github.com/Adirelle/AdiButtonAuras/issues/189#issuecomment-131381093 .

Does the buff you get when someone else used the trinket ring have a duration in the default ui?