AdiButtonAuras

AdiButtonAuras

404k Downloads

Why does this Mastery weapon enchant rule not work?

arcadepro opened this issue ยท 6 comments

commented
return Configure {
        "Mark of Bleeding Hollow",
        L["Mark of Bleeding Hollow"],
        "12294", -- Mortal Strike
        "player",
        "UNIT_AURA",
        function(_, model)
            if GetPlayerBuff("player", 173322) then
                model.highlight = "good"
            end
        end,
    }

Is it a libitembuffs issue?

commented

There is a difference between 12294 and "12294".

commented

Btw this is a just a guess. Lua supports coersion, so this would normally not be an issue but since ABA expects either a table or a number I think we are picky about the exact type of the passed value. We do use "item:" for items though, so maybe that causes the problem. Just try it that way and tell me the result. I'm writing this from my phone and the response is from the top of my head. Haven't looked at ABA's code for some time

commented

Tried without quotes, Still doesn't work.

I don't think that's the issue because I have a few rules like:

    return Configure {
        "Blast Furnace Door",
        L["Blast Furnace Door Buff."],
        "6572", -- revenge
        "player",
        "UNIT_AURA",
        function(_, model)
            if GetPlayerBuff("player", 177056) then
                model.highlight = "good"
            end
        end,
    }

that work.

I feel like the Bleeding Hollow Enchant just isn't recognized. It certainly isn't in libitembuffs.

commented

I don't see why it should be in LIB. If the IDs are correct, it should work like it is.

commented

I can reproduce your results with buffs that don't have a caster (the 8th return of UnitAura is nil). Don't know if this is the causing the issue, this is probably something @Adirelle has to look at.

commented

Ok, thanks for the replies.