AdiButtonAuras

AdiButtonAuras

404k Downloads

Hunter spells not working correctly

valepu opened this issue ยท 9 comments

commented

Hello,
I wanted to report that some Hunter spells aren't working:

Bestial Wrath: No border is shown when i use it.
I thought it could've been because of the 4pcs set bonus but doing it naked didn't do anything.
It would be nice to have the brutal kinship stacks on the button too

Intimidation: No border is shown when an enemy is already stunned.
I have noticed that the addon tracks the Intimidation debuff cast by myself on an enemy (which i think is wrong since the debuff is cast by my pet)...but i think it should just check if the enemy is already stunned since intimidation is a stun

Focus fire: Either it doesn't work or it does exaclty what the blizzard interface already does (since on the configuration it says it checks wheter my pet has a "frenzy" buff).
I think it would be more useful if it just showed a bad border whenever i had the focus fire buff going on

Explosive trap: no border is shown.
Mobs in the area of effect of the trap don't have any debuff, also i think it should be more useful if it showed a bad border for the duration of the effect once it triggers (i'm not sure if it's possible, though)

Freezing trap: No border is shown.

Also, if i activate trap launcher then go in the "spells" section in the AdiButtonAuras configuration, the traps are not taken in consideration as spells that can have an aura

Master's Call: no border is shown when i have the buff.
I think it should also track if my target has master's call buff already

Camouflage: no border is shown when i use it.

commented

Following status if Adirelle/LibPlayerSpells-1.0#9 gets merged:

  • Bestial Wrath: shown when The Beast Within is on the player
  • Bestial Wrath (Brutal Kinship stacks): needs ABA rule, don't see much use in that one
  • Intimidation: is added correctly through DRData (ctrlstun category), probably needs ABA rule, will take a look later
  • Focus Fire: shown when Focus Fire is on the player
  • Explosive Trap: cannot be fixed when there is no aura
  • Freezing Trap: target debuff duration shown on both variants of the spell
  • Master's Call: shown if buff on friend
  • Camouflage: shown when on player
commented

The problem with Intimidation actually expands to all spells added through DRData where the aura id is not the same as the provider spell id. We need a list of provider spells.

commented

I have merged Rainrider's PR and tagged ABA with '1.4' to publish a new version.

I will take a look later to the remaining issues.

commented

Adi, do you need the provider spell ids? If so we could split the work unless you plan on doing this automagically by parsing wowhead data.

commented

I am not sure to give some time in DRData since I will have to rewrite it all when WoD will come. By the way, the purpose of DRData is to track the DR. Using it in ABA is handy but it is a misuse and that is why it does not work quite right.

commented

Now I'm considering adding the providers to DRData, without breaking the existing API. That should help displaying the spells right in ABA.

commented

That's nice, please tell me if I could be of any help

commented

The whole thing is wired. Now I need to inject proper data into DRData-1.0 :-)

commented

AdiAddons/DRData-1.0@80ebc7d should fix the issue with Intimidation.

I noticed most of hunter crowd-control debuffs are listed in LibPlayerSpells as well. I am not sure I should keep them there, since they should be in DRData-1.0 too. By the way, I started updated DRData-1.0, I'll track the update in this ticket: AdiAddons/DRData-1.0#1.

I won't show Brutal Kinship on BW. This has little added value since you're going to spam attacks anyway.