AdiButtonAuras

AdiButtonAuras

404k Downloads

Rogue Shadow Blades buff overrides Revealing Strike Aura

dafzor opened this issue ยท 6 comments

commented

the following code in LibPlayerSpells-1.0\data\Rogue.lua:

[121471] = {  Shadow Blades =>
     1752,  Sinister Strike
    84617,  Revealing Strike
    51723,  Fan of Knives
     1833,  Cheap Shot
     8676,  Ambush
      703,  Garrote
},

overrides the aura already displayed on Revealing Strike, since the duration is already shown on the cd button duplicating it by hiding other debuff information is unneeded and unwanted. Commenting it out resolves the issue.

commented

This should go to LPS issue tracking.

commented

Well... technically the data in LPS isn't wrong, it's just how it's displayed in ABA that causes an issue due to it overriding existing and more important auras. Which was why I though it might be more fitting to
put it here.

commented

Normally, LPS will display the buff with the shorter duration if more than one are defined for the same provider/modified spell. Thus, if you see a running timer for shadow blades on revealing strike, it means shadow blades will drop before revealing strike. Target switching could be a problem here, but I don't see ABA as a replacement for the display of debuffs.

Also LPS is meant as a tool for describing the player spells and their interactions. ABA is a display. So if this is perceived as an issue, it is definitely an ABA one I think.

commented

I totally use ABA as my single source of debuff information though, so some people do use it like that.

commented

Would also like to say that by having both show it becomes ambiguous if Revealing strike duration is currently higher then Adrenaline Rush or if it's no longer present.

commented

Shadow Blades has been removed in WoD.