AdiButtonAuras

AdiButtonAuras

404k Downloads

Failed CI feedback and Github release

Rainrider opened this issue ยท 8 comments

commented

@Adirelle for some reason we don't get feedback from TravisCI anymore and Github releases fail.

The last commit with feedback is af15d1a.
The last proper build is https://travis-ci.org/github/AdiAddons/AdiButtonAuras/builds/537557370.

The builds fail with:

Creating GitHub release: https://github.com/AdiAddons/AdiButtonAuras/releases/tag/9.0.0
Error! (401)
{
  "message": "Bad credentials",
  "documentation_url": "https://docs.github.com/rest"
}

Would you mind checking on a solution as I don't have much of access here. I'm also fine with moving to Github Actions, if you want to make the switch.

commented

I have done the steps described in the linked page. Tell me if it fixes something, or not.

Swithing to Github Actions sounds interesting, too. However, I do not have much time to do it myself now, so feel free to try it yourself.

commented

Seems to work now, thanks!

I can switch to Actions but you will have to add the secrets to github. Would be good if you keep the names CF_API_KEY and
GITHUB_OAUTH like in here.

commented

@Adirelle done :)

Build with errors: https://github.com/AdiAddons/AdiButtonAuras/actions/runs/309550734 (check the annotations both in the build overview and in the Lint step of the build job)

I also added conditional building - only tags will be pushed to CurseForge, all builds will be pushed Github (not sure if this works as you haven't added the secrets yet).

Tell me if you think.

commented

Nice, though github does not create a link from the report to the source file.

I will try to take a look at the secrets this weekend.

commented

Would be good if you keep the names CF_API_KEY and
GITHUB_OAUTH like in here.

Done for CF_API_KEY.
I cannot add a secret named GITHUB_OAUTH because "secret names must not start with the GITHUB_ prefix." but a token is automatically provided for Actions.

commented

According to its code, BigWigsMods/packager only uploads tagged versions, so I suggest using the actions/upload-artifact action.

commented

cf. #355

commented

I have merged the PR, updated the badge and removed travis-ci webhook, so we continue with github actions.