Which version of AdiButtonAuras are you using (enter the exact version number here)?

every version since BfA

How did you install the addon (twitch client/manually)?

twitch client, now curseforge

If using the twitch client, what type of release did you install (alpha/beta/release)?

tried all

Which type of installation did you choose (nolib/normal)?

normal

Dont have error report, game just randomly crashes (windows report 1002, application hang, if thats any help)
This occurs only on monk, not on my other characters.
Its not addon conflict - had this issue on fresh install with only this addon.
i know it sounds weird, took my long time to pinpoint, but without this addon enabled on my monk i dont have any crashes.

@IngeniousDox I understand your fix is:

local remaining = GetPetTimeRemaining()
if remaining then
	if remaining > 600000 then
		remaining = 600000
	end

	model.expiration = GetTime() + remaining / 1000
	model.highlight = 'good'
end

I will try this. I also experienced this and only on monk. I also put this update in shaman as it has same code there tho I never had problem with my two shamans.

I know this has a long history, but wanted to confirm that I also have the problem. AdiButtonAuras causing game lockup (presumably some kind of infinite event loop, since it does not trigger any "script ran too long").

I've had it longer than Shadowlands. I first noticed it towards the end of BfA during horrific visions, where it would lock up at least once almost every vision on Monk. But I only discovered what addon was causing it this week.

For me (a) it is defintitely AdiButtonAuras, it happens with that as the only addon loaded, and (b) is is definitely timed with Xuen or Niuzao expiring (which is why I think so many other people have reported it as triggered by other abilities), and does not happen at any other times. It seems more likely to happen in combat, but I have observed one out-of-combat lockup.

Edit: For my fix, I have removed the 'InvokePet' configure section and just replaced it with the buffaliases.

            SelfBuffAliases {
                    123904, -- Invoke Xuen, the White Tiger
            },

            SelfBuffAliases {
                    132578, -- Invoke Niuzao, the Black Ox
            },

I expect there is some serious bug in ABA that should be fixed though, as this may show up other places.

Same Issues to me and my monk (only monk). WoW client seems to freeze in a sort of "white" screen. I used to have this problem for a longer time (already back in BfA and still in Shadowlands). Since deactivating Adibuttonauras the problem is gone.
I could not identify it happening using a single spell. Happens randomly by using different monk abilities.

Same issue here. If i play Windwalker the game freezes randomly in Dungeons and Torghast. On Brewmaster the freezes only happens in Torghast. After disabling AdiButtonAura i have no freezes any more.

I don't think it's related to conduits/soulbinds/anything SL, as I had this issue back into BfA. I only have one monk so I can't narrow it down, but my monk is Horde, Pandaren, Night Fae. talents=1222232. The only thing different from what 99% of players would be using is I have Chi Torpedo instead of Tiger's Lust as the tier 2 talent. It's hard to see how Roll being replaced with Chi Torpedo would be the issue, though as I said in the PR I do have a suspicion it might be related to being in the middle or at the end of a Chi Torpedo as the pet expires.

Now that there's an updated version unless I downgrade there's no change to find a reproducable test, unless it's not fixed. At this point we are waiting on enough evidence to prove the lack of an issue.

The latest version (9.1.0) uses the totem API to track Xuen and the corresponding buff to track Niuzao. Please give it a try on a monk and tell me if the issue still persist.

I was not able to to reproduce this issue even a single time. If it is bound to conduits or whatever they are called now, please be specific about which ones. Please DO NOT post comments only stating you having the same problem, you can "upvote" by reacting to the first comment in this issue, this is an indicator enough for me and helps keep the thread tight. Only comment here if you have something useful to add - like exact steps to reproduce - class/spec/coventants whatever you think is relevant and helps reproduce the issue RELIABLY. Thank you for your understanding!

Confirming issue. More specifically, only appears to be an issue while playing windwalker. Occurs in group settings, in dungeons, during combat. Increased chances when popping storm, earth, fire and spinning crane kick in high aoe, but has occurred just moving in combat. Client freezes as if graphic lockup. Does not occur on any other class or monk spec I've played.

It won't be possible for me to test this. Also the monk data has not been updated since the start of the last expansion. If you could pinpoint a single spell or rule (or a combination there of) that relyably crashes it, it would help.

Same issue here. Been trying to track down the issue for days before I realized it's been happening since I leveled my monk (and wasn't happening on priest). I turned off every addon until I narrowed it down to this. Hoping you find a way to fix it, I love this addon and there's no real alternative.

It won't be possible for me to test this. Also the monk data has not been updated since the start of the last expansion. If you could pinpoint a single spell or rule (or a combination there of) that relyably crashes it, it would help.

Hello. I encountered same issue in raid on my Windwalker. I can provide screenshots of warcraftlogs(private logging).

Here is the segment where the crash happened.

This segment with damage abilities casted.

Here is my casts at this moment.

Here is my buffs at this moment.

I can provide more if needed. I can also contact you via discord or something else to stream you this private log.

Thank you for this addon. Its really useful. Hope you can fix this.

This is quite the bug report, thanks a lot for the effort.

Following problems for me here:

• I haven't played monk since the end of Legion (my monk is lvl 45), I played a Brewmaster back then and I don't raid, so the screens above don't make much sense to me
• The monk data is out of date, both for ABA and LPS, so I can hardly justify spending time looking for something that might disappear if someone would take the time to update the data
• Addons being able to crash the game is actually something that should not happen and maybe you should file a bug report with Blizzard as well, especially when their crash reports might make a lot more sense to them than to me (I can imagine this won't be high on their priority list though)

What you could try is turning all rules off, then activate them one by one, maybe you could pin it down this way. Maybe play with your addon settings and see if this helps.

I'm sorry but other than that I really don't know where or how to look for the bug. The only way for me is to either reproduce the bug reliably on my account so I can debug locally, or you pin point the issue close enough that I could take a better guess on what the reason might be.

Thanks again for your effort and sorry for not being able to help more.

Happens for me, too on my Windwalker Monk alone.
When I disable the addon, everything works fine. The issue is noticable by the game freezing and utilizing 100% of my CPU.

However, I was able to narrow it down to two distinct events:

• Roll (mid-air)
• Flying Serpent Kick (mid-air)

This must have something to do with the game "locking" your controlls while those abilities are used. Sounds like a fight for locks/resources/deadlock?

It also does not matter whether it's infight or not. Here is a list of my addons:

Addons.txt

I'm almost entirely certain this has to do with the despawning of Invoke Niuzao and Invoke Xuen. This does not seem to occur with Invoke Chi-ji and Invoke Yu'lon. I have tentatively turned off support for these spells to determine if it is the culprit.

It is not exclusive to pets. It happens to me without any pets out during Roll/Flying Serpent Kick, as written above.
I would not solely focus on that.

I have this bug. I'm going to test disabling the rule. But I looked at the code and wondered if something was going wrong with "GetPetTimeRemaining()". So I made a simple macro:

/run local milli = GetPetTimeRemaining(); print("Pet time remaining: "..milli.." milliseconds!");

And just pressed it for a bit. Turns out it doesn't go to 0, it counts down to 0 and then goes to 4294967239 or something for a bit, and then becomes nil. So that means "model.expiration" gets a very huge number. Perhaps this messes something up for the overlay somehow?

And just for the record, the total game freeze also happens with Shaman class, and then improved elemental pets and leaving an instance when the pet is about to despawn. However there I can't see any big numbers. But since the freeze happens only during loading, that could be different while "zoning". This is however the only temporary pet where the same "GetPetTimeRemaining()" is used.

It also seems unnecessary to check pet duration, at least for monks: both Invoke Niuzao and Invoke Xuen give buffs to the player now, which may be more reliable if the pet duration API is in question. I personally have also observed erratic time behavior from the highlight border on these spells: often the pets seem to linger longer after the timer appears to run out, yielding an active highlight with no apparent duration briefly before the pet finally despawns and the highlight is removed.

It also seems unnecessary to check pet duration, at least for monks: both Invoke Niuzao and Invoke Xuen give buffs to the player now

IIRC those buffs did not have associated durations, that's why I opted to use the pet timer for this.

And just pressed it for a bit. Turns out it doesn't go to 0, it counts down to 0 and then goes to 4294967239 or something for a bit, and then becomes nil. So that means "model.expiration" gets a very huge number. Perhaps this messes something up for the overlay somehow?

Out of the top of my head, I would say this is not the issue. We had this at some point in the past and I think the timer is clamped at some value of two days or something (not sure though, might have to check it either way)

I personally have also observed erratic time behavior from the highlight border on these spells: often the pets seem to linger longer after the timer appears to run out, yielding an active highlight with no apparent duration briefly before the pet finally despawns and the highlight is removed.

This is because the API returns a value and ABA has an upper threshold for showing timers (15 min default I think). So if the number is huge, you just get the border but no timer. This is working as intended.

However, I was able to narrow it down to two distinct events:

• Roll (mid-air)
• Flying Serpent Kick (mid-air)

This must have something to do with the game "locking" your controlls while those abilities are used. Sounds like a fight for locks/resources/deadlock?

I would try to check this since it can be done on a lower level monk. However I won't have the time for it till mid-march so something like at least, just that you know.

I clamped it myself to 1 minute in the callback functions for the overlay. (Since pets certainly don't last longer then 1 minute atm.) And I'm testing with that. Thus far I haven't frozen, but as usual this could be luck. But I haven't played much and monk is an alt, and shaman I only played for getting the Love is in the Air mount. I'll keep testing.

For me, I normally froze like this:

• Monk, when summoning my Xuen.
• Monk, when my pet was out (and perhaps about to expire) combined with a short movement ability: Flying Serpent Kick, Whirling Dragon Punch, Roll.
• Monk: When hearthstoning/leaving instance while Xuen was about to expire
• Shaman: When hearthstoning/leaving instance while my shaman Primal Elementalist pet was up and about to expire.

There could be other freezes, but these are the only ones I experience, so I'll focus on this for now.

EDIT: One thing that has changed since 9.0.1 is that conduits can change the duration of both Xuen, and the elementals from shaman. And the first time I hung on monk was right after that patch.

IIRC those buffs did not have associated durations, that's why I opted to use the pet timer for this.

This no longer seems to be true. Invoke Niuzao applies buff 132578 and this seems to have a duration that ordinary buff addons and indicators understand (and that shows up on tooltip and counts down interactively).

I'm having issues as well with no rhyme or reason I can see. Is there any updates on this issue?

Since I capped the max 'remaining' to 600000 (10 minutes), I have not had a hang on monk. I made it 10 minutes because in Torghast the pets can get longer then the 1 minute that I had above. I have played around 10 hours last week on monk and really tried to trigger the freeze again, but wasn't able.

Now, I don't know if there any other freezes, but this case on monk seems fixed for me with this. The only other freeze I can remember is something on warrior when I did a battleshout right after joining a world boss group. However I simply can't repeat that, and I can't even be sure it has even got anything to do with this addon.

Just a heads-up from my side: After having the Addon disabled for over two months, none of the freezes happened again.
So its definitely AdiButtonAuras.

My fix worked. Haven't frozen at all anymore in the past 2 months.