AdiButtonAuras

AdiButtonAuras

404k Downloads

Warlock Havoc is permanently shining

dafzor opened this issue ยท 6 comments

commented

dafzor@53ec19b and dafzor@7080851 (and dafzor@03d4581 for grammar) allows to disable the shine wile keeping the other beneficial aspects of it.

PS: Feel free to give feedback if i'm doing anything wrong here (new to the github thing)

commented

It is supposed to shine only in combat, when Havoc is not on cooldown and found neither on the player nor the target. Does it shine out of combat or on cooldown ?

commented

Reverted to the version current on your main branch and yes, it shines constantly except when the buff is active on target/self, the changes I made do not change that behavior, they just make the shine able to be toggled off without removing the buff/debuff notification.

PS: It's possible the out of combat shine is due to me having changed global options.

commented

The suggestion display should not be affected by the combat option, but there may be a bug. How are those two options ?

commented

"No Flash on Cooldown" and "No Flash out of Combat" are both disabled on the global settings

commented

Does Adirelle@e8ebb59 change something ?

commented

Tested it and now it an now it only shines when in combat and only when not in use or cd, still the shine is still impossible to turn off independently of the beneficial buff/debuff aura so I'll continue to use my modification.