Warlock Havoc is permanently shining
dafzor opened this issue ยท 6 comments
dafzor@53ec19b and dafzor@7080851 (and dafzor@03d4581 for grammar) allows to disable the shine wile keeping the other beneficial aspects of it.
PS: Feel free to give feedback if i'm doing anything wrong here (new to the github thing)
It is supposed to shine only in combat, when Havoc is not on cooldown and found neither on the player nor the target. Does it shine out of combat or on cooldown ?
Reverted to the version current on your main branch and yes, it shines constantly except when the buff is active on target/self, the changes I made do not change that behavior, they just make the shine able to be toggled off without removing the buff/debuff notification.
PS: It's possible the out of combat shine is due to me having changed global options.
The suggestion display should not be affected by the combat option, but there may be a bug. How are those two options ?
"No Flash on Cooldown" and "No Flash out of Combat" are both disabled on the global settings
Does Adirelle@e8ebb59 change something ?