Warlock: Corruption, Drain Life, and Drain Soul have no timers.
nomoon opened this issue ยท 6 comments
I've tried to create a custom rule for spell 172 (corruption), but it doesn't seem to do anything.
That part is correct, Corruption's dot spell on the target has the id http://www.wowhead.com/spell=146739 what is missing is the correspondence to the actual button id which is 172.
So after https://github.com/Adirelle/LibPlayerSpells-1.0/blob/master/data/Warlock.lua#L109 you just need to add:
-- Map aura to provider
[146739] = 172,
That should make the aura show up in the button, should be added in the next release.
Possibly https://github.com/Adirelle/LibPlayerSpells-1.0/blob/master/data/Warlock.lua#L92 is the issue?
This makes sense, but when I make the change the Corruption button still doesn't display anything and the config mode doesn't turn the icon green as a known spell.
Could be that we got the spell id wrong, if you want to do some digging of your own there's https://github.com/Adirelle/SpellDevInfo which allows you to see the spell ids by hovering with a mod key pressed.
There's a lot of specs many Adirelle or anyone else that's been contributing don't play so stuff like that tends to lag a bit behind. So any help bringing missing auras to light would be most appreciated.
Awesome, thanks for pointing out that dev addon. I'm happy to do some mods myself and put in a PR. Will see if I can solve. Was dependent on InlineAuras for years so best to pay it forward ;)
