Suggestions from a PM on Curse:

Plague Leech(123693)

Flash when off CD
AND
while diseases (Frost Fever: 55095, Blood Plague: 55078) OR Necrotic Plague (155159) are on target
AND
(If possible to code) while two runes are fully-depleted

Soul Reaper (Unholy 130736)

Shows Hint when target is below 45% health when level is 92+ and spec is Unholy
Improved Soul Reaper perk: http://www.wowhead.com/spell=157342

Blood Tap

Flash when you have 10 or more stacks of Blood Charge.
Would be very useful to have flash indicators for 5 and 10.

Raise Dead

Flash when Pet isn't active.
Simply as a reminder to summon your pet.

Plague Strike - Unholy

As Unholy, Plague Strike applies both Blood Plague and Frost Fever
Additionally, rules need to be set for Necrotic Plague

Outbreak

Same rules as Plague Strike.

Breath of Sindragosa

Flash while at 100 Runic Power.

Regarding PL: It's essentially the same functionality that InlineAura provided and mimics the functionality of numerous other addons that serve as reminders, tellmewhen's, etc. Frost has a ton of micromanagement to the point where addons are almost necessary to play well. Having the 2 depleted rune trigger might be too spellflashy but the other triggers aren't.

WoD is coming in 3 weeks, might as well prepare for perks and how they will change every class/spec's abilities. The 35% rule will be outdated.

You don't always want to make use of BT at 5 charges, it's usually pooled until we have to use it. Having a flash at 10 charges serves as a reminder that you're about to overcap on charges and thus need to spend. Having the option to flash at either 5 or 10 would be ideal.

For PS, agreed I didn't think that suggestion through.

Outbreak, currently grayed out.

BoS, same as above, WoD is coming in 3 weeks, might as well prepare!

You're basically getting into 'spellflash' territory here aka 'Play the game for me'. I don't think ABA should be a rotation helper. I'm not a fan of these kind of rules but someone else might be I guess.

Need WoD for new Soul Reaper. Not really relevant unless someone here is on the beta.

Blood Tap flashes when it can create a rune already. I don't see the point in turning off the flash so it can flash again at 10. Could change it to hint at 5 and flash at 10. Maybe they don't have the latest build.

Raise Dead is relevant I guess and could be fixed. Experimental fix added.

Plague Strike - Unholy, meaningless really. You'd never want to Frost Fever a target and track the debuff by looking at Plague Strike since you still need to apply Blood Plague anyway.

Necrotic Plague. WoD/beta.

Outbreak. Thought this worked. Could be fixed.

Breath of Sindragosa. WoD/beta.

We will use "hints" instead of flash to differentiate them from Blizzard's flash (Blood Tap rule should be changed). The user can either disable all hints or promote some of the to flash. There already are similar rules for other classes (like for Destrulock's Havoc) so I do not mind adding some more.

I've made all the changes other than Outbreak and Plague Leech. WoD stuff is 100% untested since I'm not on beta.

I don't think tracking a disease (bad border) on Outbreak is a good idea. Might be best to hint if NO diseases are on the target.

@arcadepro
Would you mind mentioning this issue from your pull request/commit? Would you also prepend your commit messages with the class name if they are for a certain class? It makes thinks a lot easier to track down.

What is the status on the issue ?

I think it's all in, but there are 2 rules for soul reaper and they will both be active for unholy DK with the perk flashing the thing at both 35 and 45% hp. Some mechanism for disabling rules from other rules should come in place or I don't know, a lot to be considered in that case.

Does the perk appears in the spellbook ? In that case, it can be used as a provider.

It does, if I recall correctly, and it is currently set as a provider. But then both handlers will be active for unholy dk as Soul Reaper is an explicit provider for itself in the other rule.

This is a negligible issue then. The duplicate rules won't duplicate much anyway: with any number of rules, the events are handled only once per button, and the same goes for the flash animation. In the worst case the health ratio is checked twice.