Adventure Guide Lockouts

Adventure Guide Lockouts

366k Downloads

Journal no longer opens to current instance

benhamlin opened this issue ยท 5 comments

commented

When this addon is enabled, opening the dungeon journal while in a specific dungeon no longer opens that dungeon's panel. Instead, the top level 'dungeons' tab is shown.

Minor issue, but would be nice to fix if easy. Thank you for this wonderful addon.

commented

I can't reproduce your issue. Can you give me more details?

commented

It looks like there's a little more to the repro. I disabled all my other addons to make sure nothing else was interfering, here's what I saw:

After zoning into Siege, when I bring up the dungeon journal it correctly opens directly to the Siege panel. However, after doing a /reload, it opens to Siege for a split-second, then switches to the Dungeons panel. I believe something else triggers it besides /reload since I see this all the time during regular usage, but not sure what.

  • Rezoning doesn't fix it.
  • The first time after doing /reload, it lingers on the Siege panel for a second before it switches to the Dungeon panel. You can do this over and over and it takes longer to switch the first time after each /reload.
  • None of this behavior repros without the addon enabled.
commented

Can you please try replacing this (at the end of EncounterJournalSavedInstances.lua):

hooksecurefunc("EncounterJournal_ListInstances", UpdateFrames)
EncounterJournal_ListInstances()

By this:

hooksecurefunc("EncounterJournal_ListInstances", UpdateFrames)
UpdateFrames()

Instead and report me if your issue is still occuring?
Based on your report, it happens when PLAYER_LOGIN event is triggered.

commented

Yep, that fixes it!

commented

Fixed in e27a81c. Thanks for your report.