ALL THE THINGS

ALL THE THINGS

31M Downloads

World map button compatibility issues

TheKrowi opened this issue ยท 4 comments

commented

Which flavo(u)r(s) of WoW are you using?

Retail

Which server realm(s) are you in?

EU

What build number of WoW?

11.1.5.60822

Which version of ATT?

Latest release

What build number of ATT?

4.4.5

What isn't working? What was supposed to happen?

In 11.1.5 Blizzard changed the world map icons to be vertical instead of horizontal. Some addons are using this library for their world map icons: https://github.com/TheKrowi/Krowi_WorldMapButtons (I created this library). I updated the library to reflect Blizzard's changes to also align the icons vertically. The result is that the ATT icon is hiding 1 or 2 other icons if multiple addons add their own via that library (Handynotes plugins, ...)

Screenshot

Some addons enabled that use the library to add icons to the world map.

Image

Same screenshot but with ATT world map icon enabled:

Image

Steps to reproduce the behavior.

Enable ATT (with world map icon shown) and the following addons:

Are you experiencing any lua errors?

No response

Anything else?

No response

commented

@TheKrowi Does your addon include a way for ATT to hook in our button to your alignment logic for when it's enabled for someone? Our functionality essentially just creates a Button object and does SetPoint to attach to the world map frame following the default buttons. If we can just instead 'give the Button' to your addon if existing or call your addon to create the Button for us to modify or whatever the process would be, then we can work with that.

Guess I can do a LibStub:GetLibrary and just add our button if that exists.

commented

@TheKrowi Can you review #2000 if you have time to verify if that appears to be acceptable logic to interface properly with your lib? I'll try to test out with the specific addons you mentioned to make sure it works as expected when I can.

commented

This is resolved now.

@TheKrowi I'd recommend checking in your lib that the Refresh method exists on the added button before attempting to call it. This is not a standard function within the WoW Widget stack for a 'Button' frame.

commented

@ImUnicke, I'm so sorry to get back only now to you. I had a look at the implementation. So what you do is, when you detect an addon with Krowi_WorldMapButtons-1.4, you add an empty button and put the ATT icon on top of it, right? You do not use it yourself in your libraries.

This will work as long as ATT is the first addon that loads that is adding an icon. If ATT is not the first, the icon will show somewhere in the middle with another design (ATT "big" icon) compared to the default blizz round one.

At closer inspection and testing, ATT manages to add it's icon as the last one to the list making it so it appears at the bottom. How do you manage to do this, is ATT loading the world map icon very late in the process (PLAYER_ENTERING_WORLD) or is this pure coincidence? Point is, if an addon manages to add its icon after ATT, it will have some weird effects. Problems for when they occur I guess. Works great with mentioned addons at the beginning of the ticket. Tnx for the quick support!