AltReps

AltReps

13.7k Downloads

Config Changes Don't Reflect/Require Change in Number of Expansions

Ophilla opened this issue · 4 comments

commented

Expected Behavior

Changing the number of expansions, which expansions, and which factions to display reflects immediately and persists through reloads, logs in and out, and possibly between characters.

Current Behavior

Initially, changing the number of expansions causes no expansions to show at all. Changing the number a second time reflects the correct number of expansions, which persists after logs, character switches, etc.

Enabling or disabling individual expansions USUALLY persists. I was showing only 5 Legion factions when I turned off all other addons for testing, after which all Legion, Shadowlands, and Dragonflight factions returned and I received an error. After this point, I turned off Dragonflight, Shadowlands, and several Legion factions again, but this caused no reputations to show and the correct results did not reflect until I modified the number of expansions to show.

First Error

Message: Interface/AddOns/AltReps/Core.lua:2399: attempt to concatenate field 'MaxRenown' (a nil value)
Time: Mon Jan 30 15:21:33 2023
Count: 10
Stack: Interface/AddOns/AltReps/Core.lua:2399: attempt to concatenate field 'MaxRenown' (a nil value)
[string "@Interface/AddOns/AltReps/Core.lua"]:2399: in function `ShowToonFactionTooltip'
[string "@Interface/AddOns/AltReps/Core.lua"]:1641: in function <Interface/AddOns/AltReps/Core.lua:1639>

Locals: parent = StatusBar {
0 =
OnBackdropLoaded = defined @Interface/SharedXML/Backdrop.lua:152
GetBackdropColor = defined @Interface/SharedXML/Backdrop.lua:390
SetupTextureCoordinates = defined @Interface/SharedXML/Backdrop.lua:214
OnBackdropSizeChanged = defined @Interface/SharedXML/Backdrop.lua:182
HasBackdropInfo = defined @Interface/SharedXML/Backdrop.lua:278
SetBackdropBorderColor = defined @Interface/SharedXML/Backdrop.lua:422
Texture = Texture {
}
GetEdgeSize = defined @Interface/SharedXML/Backdrop.lua:188
ApplyBackdrop = defined @Interface/SharedXML/Backdrop.lua:294
SetBackdrop = defined @Interface/SharedXML/Backdrop.lua:329
ClearBackdrop = defined @Interface/SharedXML/Backdrop.lua:282
GetBackdropBorderColor = defined @Interface/SharedXML/Backdrop.lua:409
GetBackdrop = defined @Interface/SharedXML/Backdrop.lua:347
SetupPieceVisuals = defined @Interface/SharedXML/Backdrop.lua:246
SetBackdropColor = defined @Interface/SharedXML/Backdrop.lua:399
Value = FontString {
}
SetBorderBlendMode = defined @Interface/SharedXML/Backdrop.lua:266
}
arg =

{
factionId = 2511
toonId = "Aephyl - Stormrage"
}
factionId = 2511
toonId = "Aephyl - Stormrage"
toon =
{
Show = true
SortOrder = 25
Reps =
{
}
LFaction = "Alliance"
Faction = "Alliance"
Class = "PALADIN"
LClass = "Paladin"
Server = "Stormrage"
}
faction =
{
Show = true
For = "Alliance;Horde"
Name = "Iskaara Tuskarr"
ExpansionId = 10
}
rep =
{
Max = 6000
Current = 0
RenownLevel = 0
Standing = 5
}
standingLine = 2
(*temporary) = defined @Interface/AddOns/AltReps/Libs/LibQTip-1.0/LibQTip-1.0.lua:1295
(*temporary) = Frame {
0 =
regularFont = GameTooltipText {
}
OnRelease = defined @Interface/AddOns/AltReps/Core.lua:2550
layoutType = "TooltipDefaultLayout"
headerFont = GameTooltipHeaderText {
}
GetBackdropColor = defined @Interface/SharedXML/SharedTooltipTemplates.lua:191
key = "AltRepsIndicatorTooltip"
SetBackdropBorderColor = defined @Interface/SharedXML/SharedTooltipTemplates.lua:195
scrollFrame = ScrollFrame {
}
autoHideTimerFrame = Frame {
}
columns =
{
}
SetBorderBlendMode = defined @Interface/SharedXML/SharedTooltipTemplates.lua:203
scrollChild = Frame {
}
colspans =
{
}
TooltipBackdropOnLoad = defined @Interface/SharedXML/SharedTooltipTemplates.lua:172
width = 112.506180
GetBackdropBorderColor = defined @Interface/SharedXML/SharedTooltipTemplates.lua:199
labelProvider =
{
}
height = 31.074077
SetBackdropColor = defined @Interface/SharedXML/SharedTooltipTemplates.lua:187
lines =
{
}
NineSlice = Frame {
}
}
(*temporary) = 2
(*temporary) = 2
(*temporary) = 0
(*temporary) = " / "
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = Frame {
0 =
regularFont = GameTooltipText {
}
OnRelease = defined @Interface/AddOns/AltReps/Core.lua:2550
layoutType = "TooltipDefaultLayout"
headerFont = GameTooltipHeaderText {
}
GetBackdropColor = defined @Interface/SharedXML/SharedTooltipTemplates.lua:191
key = "AltRepsIndicatorTooltip"
SetBackdropBorderColor = defined @Interface/SharedXML/SharedTooltipTemplates.lua:195
scrollFrame = ScrollFrame {
}
autoHideTimerFrame = Frame {
}

Second Error

This is the version of the error that was given after I re-enabled BugGrabber/BugSack.

51x AltReps/Core.lua:2399: attempt to concatenate field 'MaxRenown' (a nil value)
[string "@AltReps/Core.lua"]:2399: in function `ShowToonFactionTooltip'
[string "@AltReps/Core.lua"]:1641: in function <AltReps/Core.lua:1639>

Locals:
parent = StatusBar {
0 =
PixelSnapDisabled = true
OnBackdropLoaded = defined @SharedXML/Backdrop.lua:152
GetBackdropColor = defined @SharedXML/Backdrop.lua:390
SetupTextureCoordinates = defined @SharedXML/Backdrop.lua:214
OnBackdropSizeChanged = defined @SharedXML/Backdrop.lua:182
HasBackdropInfo = defined @SharedXML/Backdrop.lua:278
SetBackdropBorderColor = defined @SharedXML/Backdrop.lua:422
Texture = Texture {
}
GetEdgeSize = defined @SharedXML/Backdrop.lua:188
ApplyBackdrop = defined @SharedXML/Backdrop.lua:294
SetBackdrop = defined @SharedXML/Backdrop.lua:329
ClearBackdrop = defined @SharedXML/Backdrop.lua:282
GetBackdropBorderColor = defined @SharedXML/Backdrop.lua:409
GetBackdrop = defined @SharedXML/Backdrop.lua:347
backdrop = Frame {
}
SetupPieceVisuals = defined @SharedXML/Backdrop.lua:246
SetBackdropColor = defined @SharedXML/Backdrop.lua:399
Value = FontString {
}
SetBorderBlendMode = defined @SharedXML/Backdrop.lua:266
}
arg =

{
factionId = 2510
toonId = "Awanaj - Area 52"
}
factionId = 2510
toonId = "Awanaj - Area 52"
toon =
{
Class = "MONK"
Show = true
SortOrder = 5
Reps =
{
}
Faction = "Horde"
LFaction = "Horde"
LClass = "Monk"
Server = "Area 52"
}
faction =
{
Show = true
For = "Alliance;Horde"
Name = "Valdrakken Accord"
ExpansionId = 10
}
rep =
{
Current = 0
Max = 6000
RenownLevel = 0
Standing = 5
}
standingLine = 2
(*temporary) = defined @AltReps/Libs/LibQTip-1.0/LibQTip-1.0.lua:1295
(*temporary) = Frame {
SetBorderBlendMode = defined @SharedXML/SharedTooltipTemplates.lua:203
OnLeave = defined @gmGuildFriends/core.lua:161
OnRelease = defined @AltReps/Core.lua:2550
layoutType = "TooltipDefaultLayout"
headerFont = GameTooltipHeaderText {
}
GetBackdropColor = defined @SharedXML/SharedTooltipTemplates.lua:191
key = "AltRepsIndicatorTooltip"
SetBackdropBorderColor = defined @SharedXML/SharedTooltipTemplates.lua:195
regularFont = GameTooltipText {
}
scrollFrame = ScrollFrame {
}
backdrop = Frame {
}
autoHideTimerFrame = Frame {
}
columns =
{
}
0 =
scrollChild = Frame {
}
colspans =
{
}
TooltipBackdropOnLoad = defined @SharedXML/SharedTooltipTemplates.lua:172
width = 155.325928
GetBackdropBorderColor = defined @SharedXML/SharedTooltipTemplates.lua:199
labelProvider =
{
}
lines =
{
}
height = 44.822224
SetBackdropColor = defined @SharedXML/SharedTooltipTemplates.lua:187
NineSlice = Frame {
}
slider = Slider {
}
}
(*temporary) = 2
(*temporary) = 2
(*temporary) = 0
(*temporary) = " / "
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = Frame {
SetBorderBlendMode = defined @SharedXML/SharedTooltipTemplates.lua:203
OnLeave = defined @gmGuildFriends/core.lua:161
OnRelease = defined @AltReps/Core.lua:2550
layoutType = "TooltipDefaultLayout"
headerFont = GameTooltipHeaderText {
}
GetBackdropColor = defined @SharedXML/SharedTooltipTemplates.lua:191
key = "AltRepsIndicatorTooltip"
SetBackdropBorderColor = defined @SharedXML/SharedTooltipTemplates.lua:195
regularFont = GameTooltipText {
}
scrollFrame = ScrollFrame {
}
backdrop = Frame {
}
autoHideTimerFrame = Frame {
}
columns =
{
}
0 =
scrollChild = Frame {
}
colspans =
{
}
TooltipBackdropOnLoad = defined @SharedXML/SharedTooltipTemplates.lua:172
width = 155.325928
GetBackd

commented

yea, still broken...

settings don't save when changing what factions/expansion you want to see

commented

Hey Alfakennyone,

I'm very sorry about the delay with this. Strangly, the issue you were experiencing above looks to be the same as an issue I noticed with tooltips with characters that are currently on 0 renown. I have just pushed out a fix (along with adding the new reps and another fix) that should be live soon.

Please let me know if this works for you, and again, I'm sorry for the delay!

commented
commented

Amazing! Thanks for raising :)