Lua error with TWW prepatch

Question

Lua error with TWW prepatch

KatyPurry opened this issue 2 months ago · 28 comments

KatyPurry commented 2 months ago

Hello, I got a lua error with TWW prepatch (addon version v0.42.8)

Message: Interface/AddOns/AngrierWorldQuests/Config.lua:461: attempt to call global 'InterfaceOptions_AddCategory' (a nil value)
Time: Wed Jul 24 09:27:31 2024
Count: 1
Stack: Interface/AddOns/AngrierWorldQuests/Config.lua:461: attempt to call global 'InterfaceOptions_AddCategory' (a nil value)
[string "@Interface/AddOns/AngrierWorldQuests/Config.lua"]:461: in function `CreatePanel'
[string "@Interface/AddOns/AngrierWorldQuests/Config.lua"]:528: in function `?'
[string "@Interface/AddOns/AngrierWorldQuests/Core.lua"]:122: in function `ForAllModules'
[string "@Interface/AddOns/AngrierWorldQuests/Core.lua"]:130: in function `?'
[string "@Interface/AddOns/AngrierWorldQuests/Core.lua"]:10: in function <Interface/AddOns/AngrierWorldQuests/Core.lua:6>

Locals: self = <table> {
}
panel = Frame {
 name = "Angrier World Quests"
}
(*temporary) = nil
(*temporary) = Frame {
 name = "Angrier World Quests"
}
(*temporary) = "attempt to call global 'InterfaceOptions_AddCategory' (a nil value)"
Addon = <table> {
 Modules = <table> {
 }
 Version = "v0.42.8"
 Name = "Angrier World Quests"
 ModulePrototype = <table> {
 }
}

Shauren commented a month ago

#53

KatyPurry · Answer 1 · 2024-07-24T11:04:41.000Z

No problem, thank you for your answer and good luck !

GurliGebis · Answer 2 · 2024-07-24T10:26:10.000Z

I am working on getting it fixed.
11.0.0 broken several things, so it takes a while to get around it all. (they rewrote the quest log)

ynazar1 · Answer 3 · 2024-07-25T18:30:16.000Z

Excitedly waiting for this to be hopefully fixed.

Super quick question. Was it THIS addon that was popping up the world quests to the overall expansion map? I can see quests in zones but not once I zoom out. I was sure that it was default feature but even with every addon disabled it's not there. I'm trying to figure out now if this changed in pre-patch or it was some addon that was doing it and is currently non-functional.

GurliGebis · Answer 4 · 2024-07-25T18:37:19.000Z

It sounds like it yes.
The problem now is that they have changed the quest log around, so I need to figure out how to add data to it, without breaking anything 🙂

ynazar1 · Answer 5 · 2024-07-25T18:45:43.000Z

You're right that was AWQs popping up the icons to the map level. Yeah that's tricky with UI and good luck. The new quest list looks like a pie of frames. LUA is always messy to code in. :(

Temporary solution: I found world quest list ... It seems more convoluted vs AWQ which i love for its simplicity.... But with some tweaking to the options it's mostly a passable stopgap.

karpana · Answer 6 · 2024-07-27T15:57:02.000Z

It sounds like it yes. The problem now is that they have changed the quest log around, so I need to figure out how to add data to it, without breaking anything 🙂

@GurliGebis
I see you carved off a branch to do some TWW work.
Do let us know if there anything we can help with (e.g. testing or similar).

GurliGebis · Answer 7 · 2024-07-27T18:19:24.000Z

@karpana I will - right now I just managed to silence the errors it throw when trying to set up the options page.
Another problem I'm trying to find a solution to, is now Blizzard has their own WQ filter for the map - so maybe we should integrate into that (if possible, doesn't look easy).

So there are several issues that needs to be fixed.

GurliGebis · Answer 8 · 2024-08-13T08:04:13.000Z

I have pushed an update (v0.42.9) which prevents the addon from throwing errors when it is loaded.
It is not ready for TWW (yet), but this at least prevents it from crashing stuff 🙂

Hayato2846 · Answer 9 · 2024-08-13T16:07:42.000Z

I have pushed an update (v0.42.9) which prevents the addon from throwing errors when it is loaded. It is not ready for TWW (yet), but this at least prevents it from crashing stuff 🙂

Sadly, can't confirm that. Getting following error with latest version:

1x AngrierWorldQuests/QuestFrame.lua:1259: hooksecurefunc(): OnSelection is not a function
[string "=[C]"]: in function `hooksecurefunc'
[string "@AngrierWorldQuests/QuestFrame.lua"]:1259: in function `?'
[string "@AngrierWorldQuests/Core.lua"]:63: in function `RegisterAddOnLoaded'
[string "@AngrierWorldQuests/Core.lua"]:102: in function `RegisterAddOnLoaded'
[string "@AngrierWorldQuests/QuestFrame.lua"]:1285: in function `?'
[string "@AngrierWorldQuests/Core.lua"]:122: in function `ForAllModules'
[string "@AngrierWorldQuests/Core.lua"]:130: in function `?'
[string "@AngrierWorldQuests/Core.lua"]:10: in function <AngrierWorldQuests/Core.lua:6>

Locals:

Thanks for your hard work!

GurliGebis · Answer 10 · 2024-08-13T18:33:01.000Z

Hmm, strange.
I see what I can do 🙂

karpana · Answer 11 · 2024-08-13T23:01:32.000Z

Super Excited @GurliGebis !!!
I see a new version in CurseForge!

SQUEE!

karpana · Answer 12 · 2024-08-13T23:38:38.000Z

@GurliGebis
alas, looks like blizz made some surprise changes that weren't on the PTR yesterday....

7x AngrierWorldQuests/Core.lua:136: attempt to call global 'GetAddOnMetadata' (a nil value)
[string "@AngrierWorldQuests/Core.lua"]:136: in main chunk

Locals:
ADDON = "AngrierWorldQuests"
Addon = <table> {
 Modules = <table> {
 }
 ModulePrototype = <table> {
 }
}
Listener = AngrierWorldQuestsListener {
}
EventListeners = <table> {
 PLAYER_ENTERING_WORLD = <table> {
 }
}
AddOnListeners = <table> {
}
ModulePrototype = <table> {
}
(*temporary) = nil
(*temporary) = "AngrierWorldQuests"
(*temporary) = "Title"
(*temporary) = "attempt to call global 'GetAddOnMetadata' (a nil value)"

ynazar1 · Answer 13 · 2024-08-14T00:15:33.000Z

That was coming... change to: C_AddOns.GetAddOnMetadata

Or better yet add in the beginning of the file that errors as needed:

local IsAddOnLoaded = C_AddOns.IsAddOnLoaded
local GetAddOnMetadata = C_AddOns.GetAddOnMetadata

I just had to fix like 20 different addons that are guilty of this :(.

Gnarfoz · Answer 14 · 2024-08-14T07:30:17.000Z

@GurliGebis alas, looks like blizz made some surprise changes that weren't on the PTR yesterday....

GetAddOnMetadata was deprecated in patch 10.1.0, over a year ago (May 2023). ;-)

It was just gated behind the deprecation CVar:
https://warcraft.wiki.gg/wiki/CVar_loadDeprecationFallbacks
https://github.com/Gethe/wow-ui-source/tree/11.0.0/Interface/AddOns/Blizzard_Deprecated

Addon developers should really test their addons after setting this CVar.

GurliGebis · Answer 15 · 2024-08-14T09:30:08.000Z

The deprecated API's has been replaced, and the hook has been disabled for now.

v0.42.10 should allow the addon to load, without causing LUA errors. (Still working on getting it working with TWW)

AcidWeb · Answer 16 · 2024-08-14T16:10:42.000Z

Why GitHub releases are gone?

AcidWeb · Answer 17 · 2024-08-14T18:29:44.000Z

In this case I would like to respectfully request other source than CF. If not GH then Wago Addons - you already have pipeline in place to release it there too.

Also what kind of issues? GH releases are quite plug-and-play.

GurliGebis · Answer 18 · 2024-08-14T18:27:14.000Z

Several of my repos started having issues with the github action upload of releases.
So since the zip file can be downloaded from curseforge the same way as here, I choose to keep it simple and focus on the addons instead of infrastructure 🙂

AcidWeb · Answer 19 · 2024-08-14T20:27:46.000Z

It is owned by Overwolf. It is a slimy company and some people don't want to support their business.

GurliGebis · Answer 20 · 2024-08-14T19:43:34.000Z

I don't remember how it was failing.
Can you explain what the problem with CF is? (It is quiet easy to just go there and click Download)

Gnarfoz · Answer 21 · 2024-08-14T21:18:22.000Z

Looking at a random other addon, it seems like the only thing you'd need to add would be the access token. Everything else seems to be in place.

jleafey · Answer 22 · 2024-08-14T22:22:20.000Z

Loaded up v0.42.10 from CurseForge and noted I was not seeing the display. BugGrabber offered me this:

14x AngrierWorldQuests/QuestFrame.lua:556: Action[SetPoint] failed because[Cannot anchor to a region dependent on it]: attempted from: Texture:SetPoint.
[string "=[C]"]: in function `SetPoint'
[string "@AngrierWorldQuests/QuestFrame.lua"]:556: in function <AngrierWorldQuests/QuestFrame.lua:548>
[string "@AngrierWorldQuests/QuestFrame.lua"]:586: in function <AngrierWorldQuests/QuestFrame.lua:584>
[string "@AngrierWorldQuests/QuestFrame.lua"]:1100: in function <AngrierWorldQuests/QuestFrame.lua:979>
[string "=[C]"]: in function `QuestLogQuests_Update'
[string "@Blizzard_UIPanels_Game/Mainline/QuestMapFrame.lua"]:869: in function `QuestMapFrame_UpdateAll'
[string "@Blizzard_UIPanels_Game/Mainline/QuestMapFrame.lua"]:227: in function `Refresh'
[string "@Blizzard_WorldMap/QuestLogOwnerMixin.lua"]:164: in function `RefreshQuestLog'
[string "@Blizzard_WorldMap/Blizzard_WorldMap.lua"]:305: in function <...rfaceBlizzard_WorldMap/Blizzard_WorldMap.lua:302>
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "=[C]"]: in function `OnMapChanged'
[string "@Blizzard_MapCanvas/Blizzard_MapCanvas.lua"]:60: in function `SetMapID'
[string "@Blizzard_WorldMap/Blizzard_WorldMapTemplates.lua"]:492: in function `GoToMap'
[string "@Blizzard_WorldMap/Blizzard_WorldMapTemplates.lua"]:550: in function `myclick'
[string "@Blizzard_FrameXML/Mainline/NavigationBar.lua"]:172: in function <Blizzard_FrameXML/Mainline/NavigationBar.lua:162>

Locals:
(*temporary) = Texture {
}
(*temporary) = "TOP"
(*temporary) = FontString {
}
(*temporary) = "CENTER"
(*temporary) = 0
(*temporary) = 8

Cannot anchor to a region dependent on it sounds like something else might have gotten greedy?

GurliGebis · Answer 23 · 2024-08-15T09:06:08.000Z

I'll look into other hosting as well, once we get this one in a working state (doing it while it doesn't work makes no sense).
@jleafey Thank you for your report 🙂 - right now the addon is broken (I'm working on fixing it - the last few releases has been to make sure it doesn't break the game if it is enabled)

jleafey · Answer 24 · 2024-08-15T18:32:18.000Z

I code a bit myself, but I am a tyro with Lua, and the WoW API has impressed me with its breadth and rate of change! I fixed a couple of add-ons myself by checking the docs online, and where they made more functions subordinate to classes it was relatively easy to fix. However, without a lot of study I get out of my depth quickly. Thanks for giving us a great addon!

…

On Thu, Aug 15, 2024, 04:06 GurliGebis ***@***.***> wrote: I'll look into other hosting as well, once we get this one in a working state (doing it while it doesn't work makes no sense). @jleafey <https://github.com/jleafey> Thank you for your report 🙂 - right now the addon is broken (I'm working on fixing it - the last few releases has been to make sure it doesn't break the game if it is enabled) — Reply to this email directly, view it on GitHub <#49 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJS2FYCGTAEGSVIX5OGIAZ3ZRRVRNAVCNFSM6AAAAABLL4LCGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJQHEZTKNBTHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

GurliGebis · Answer 25 · 2024-08-15T18:48:45.000Z

Any help is appreciated.
I have some ideas of how it might be possible to integrate into the quest log - hopefully I can get to test them soon 🙂

GurliGebis · Answer 26 · 2024-08-22T10:15:36.000Z

@Shauren Thank you, I have merged your fixes 🙂
@jleafey , @KatyPurry , @Gnarfoz , @karpana - can you all try out v0.43.0 (should be available shortly) and see if it works for you as well.
Closing ticket, please reopen if it doesn't work.

Gnarfoz · Answer 27 · 2024-08-22T18:33:00.000Z

Excellent work, @Shauren! This was the one addon that was still on my "broken since 11.0" list. ❤️

Share to