Angrier World Quests

Angrier World Quests

181k Downloads

ADDON_ACTION_FORBIDDEN

Ioney opened this issue · 9 comments

commented
1x [ADDON_ACTION_FORBIDDEN] AddOn 'AngrierWorldQuests' hat versucht die geschützte Funktion 'UseQuestLogSpecialItem()' aufzurufen.
[string "@!BugGrabber/BugGrabber.lua"]:485: in function <!BugGrabber/BugGrabber.lua:485>
[string "=[C]"]: in function `UseQuestLogSpecialItem'
[string "@Blizzard_ObjectiveTracker/Blizzard_ObjectiveTrackerShared.lua"]:94: in function <...ObjectiveTracker/Blizzard_ObjectiveTrackerShared.lua:87>

Locals:
_ = Frame {
}
event = "ADDON_ACTION_FORBIDDEN"
events = <table> {
}

Step 1: Click on a Checkbox from AWQ
Step 2: Use Special Item from Blizzard Quest List (different quest, not the checked WQ)

It is not a problem if i just click on the title of the quest on the AWQ List

commented
1x [ADDON_ACTION_BLOCKED] AddOn 'AngrierWorldQuests' hat versucht die geschützte Funktion 'Button:SetPassThroughButtons()' aufzurufen.
[string "@!BugGrabber/BugGrabber.lua"]:485: in function <!BugGrabber/BugGrabber.lua:485>
[string "=[C]"]: in function `SetPassThroughButtons'
[string "@Blizzard_MapCanvas/MapCanvas_DataProviderBase.lua"]:224: in function `CheckMouseButtonPassthrough'
[string "@Blizzard_MapCanvas/Blizzard_MapCanvas.lua"]:209: in function `AcquirePin'
[string "@Blizzard_SharedMapDataProviders/BonusObjectiveDataProvider.lua"]:97: in function <...haredMapDataProviders/BonusObjectiveDataProvider.lua:92>
[string "=[C]"]: in function `xpcall'
[string "@Blizzard_ObjectAPI/Mainline/AsyncCallbackSystem.lua"]:76: in function `FireCallbacks'
[string "@Blizzard_ObjectAPI/Mainline/AsyncCallbackSystem.lua"]:35: in function <.../Blizzard_ObjectAPI/Mainline/AsyncCallbackSystem.lua:31>
[string "=[C]"]: in function `accessor'
[string "@Blizzard_ObjectAPI/Mainline/AsyncCallbackSystem.lua"]:52: in function `AddCallback'
[string "@Blizzard_ObjectAPI/Mainline/AsyncCallbackSystem.lua"]:60: in function `AddCancelableCallback'
[string "@Blizzard_SharedMapDataProviders/BonusObjectiveDataProvider.lua"]:92: in function `RefreshAllData'
[string "@Blizzard_SharedMapDataProviders/BonusObjectiveDataProvider.lua"]:65: in function `OnEvent'
[string "@Blizzard_MapCanvas/MapCanvas_DataProviderBase.lua"]:99: in function `SignalEvent'
[string "@Blizzard_MapCanvas/Blizzard_MapCanvas.lua"]:106: in function <...aceBlizzard_MapCanvas/Blizzard_MapCanvas.lua:105>
[string "=[C]"]: in function `secureexecuterange'
[string "@Blizzard_MapCanvas/Blizzard_MapCanvas.lua"]:109: in function `OnEvent'
[string "@Blizzard_WorldMap/Blizzard_WorldMap.lua"]:148: in function <...rfaceBlizzard_WorldMap/Blizzard_WorldMap.lua:147>

Locals:
_ = Frame {
}
event = "ADDON_ACTION_BLOCKED"
events = <table> {
}

just got this too after just using the questitem (Lamplighter Firearm from Torching Lights) on the eggs.

this error doesnt blocks me from using the item, but the first error does.

commented

Looks like it is a duplicate of #59, or at least causes by the same thing.
I am working on a fix for it 🙂

commented

Please look here: #59 (comment)

Update to the release mentioned, and enable the checkbox, and then report back 🙂

commented

weirdly i only have the taint issue if I do check the box

Apparently not. Sometimes I have no problems, other times it taints and I'm not quite sure why. So far the best experience has been check box checked and a reload ui (even after logging in with it already checked). Delves seem to mess it up still sometimes.

commented

I also still have the issue. I made sure to enable taint workaround and made sure function was called. Reloaded the UI. As soon as I clicked an item in the questtracker, I got this error and only reloading the UI again cleared the error.

1x [ADDON_ACTION_FORBIDDEN] AddOn 'AngrierWorldQuests' tried to call the protected function 'UseQuestLogSpecialItem()'.
[string "@!BugGrabber/BugGrabber.lua"]:485: in function <!BugGrabber/BugGrabber.lua:485>
[string "=[C]"]: in function `UseQuestLogSpecialItem'
[string "@Blizzard_ObjectiveTracker/Blizzard_ObjectiveTrackerShared.lua"]:94: in function <...ObjectiveTracker/Blizzard_ObjectiveTrackerShared.lua:87>

Locals:
_ = Frame {
}
event = "ADDON_ACTION_FORBIDDEN"
events =

{
}

commented

Okay, so let me make sure I get this right.
You track a world quest, followed by clicking a quest button on the tracker?

commented

Okay, so let me make sure I get this right. You track a world quest, followed by clicking a quest button on the tracker?

Yes, after enabling taint workaround and reloading UI, I picked up a quest that had a on use item in the questtrack. As soon as I clicked the item in the tracker, I got the LUA error. Had to reload UI again to be able to use the item.

commented

Okay, this one threw me for a loop for quiet a while.

I managed to track it down to only happening when you untrack a world quest, not when you track it.
This pointed me to this line: https://github.com/Gethe/wow-ui-source/blob/5076663b5454de9e7522320994ea7cc15b2a961c/Interface/AddOns/Blizzard_FrameXMLUtil/Mainline/QuestUtils.lua#L457C2-L457C38

So, when a world quest is untracked, the entire objective tracker is refreshed, which taints it (since it is being called indirectly from this code).

So to workaround it, I have overwritten both the track and untrack functions (since they share local variables), and removed the call to refresh the tracker (looks like it is working just fine with it not being called).

New release incoming shortly.

commented

This has been fixed in 11.0.2-20241003-2 - please test and reopen if the issue persists (remember to enable the taint workarounds in the options dialog)