Hello,

I'd like translate APR in fr_FR. Could you adapt the local file so that I can do the translation?

Regards

This is very possible! Give me some time to adapt the files, and I'll also get you a list of all strings in the addon.

This is very possible! Give me some time to adapt the files, and I'll also get you a list of all strings in the addon.

just adapt file and i will do a Pull Requst with file translted in fr_FR

The addon requires several libraries that are not in this repository. Please download the package v19.0.0-alpha. It has all the needed files in it.

Ahah, i'm an idiot, is working.

Can you give me and example for this string :

Confirmation pop-up when " .. APR.Utilities.CHAT_GREEN .. "loot" .. FONT_COLOR_CODE_CLOSE .. "ing bind-on-pickup items will be " .. APR.Utilities.CHAT_GREEN .. "hidden" .. FONT_COLOR_CODE_CLOSE .. "

I have this error :

Date: 2023-10-28 19:34:46
ID: 1
Error occured in: Global
Count: 1
Message: ...terface/AddOns/AnnoyingPopupRemover/Localization.lua line 71:
   attempt to index field 'Utilities' (a nil value)
Debug:
   [string "@Interface/AddOns/AnnoyingPopupRemover/Localization.lua"]:71: in main chunk

OK, I created a new branch named FR_Localization and pushed the changes to it. You can download v19.0.0-alpha and use that for testing. Just copy all the strings from Localization.lua to Localization_frFR.lua and put the translations there. Don't forget to update your credit at the top of the file too!

Let me know if you have any questions, and thanks again!

In French, some messages are too long, and you can't see the end of the message.

Like :

Can you give me and example for this string :

Confirmation pop-up when " .. APR.Utilities.CHAT_GREEN .. "loot" .. FONT_COLOR_CODE_CLOSE .. "ing bind-on-pickup items will be " .. APR.Utilities.CHAT_GREEN .. "hidden" .. FONT_COLOR_CODE_CLOSE .. "

Sure, in game, load APR, then type /apr loot

Each time you use that command, it will toggle the setting on or off and print the confirmation message.

You can use the same /apr option syntax for all the other options, using the English highlighted key word. I'll have to think about how to use non-English keywords, but there should be a way to do that too.

In French, some messages are too long, and you can't see the end of the message.

I have the same issue with some English settings. I might have to redesign the options panel entirely.

For now, keep the long text. I'll deep dive into the Ace docs and see if there's a way to make that wrap. Or maybe I'll just move the common text "Hide the confirmation pop-up when" to a header, so each option becomes shorter.

For now, keep the long text. I'll deep dive into the Ace docs and see if there's a way to make that wrap. Or maybe I'll just move the common text "Hide the confirmation pop-up when" to a header, so each option becomes shorter.

A simple \n didn't work ?

You can use the same /apr option syntax for all the other options, using the English highlighted key word. I'll have to think about how to use non-English keywords, but there should be a way to do that too.

So, you have a text for GUI and text for slash command, for 2 smilars options ?

Maybe it would be a good idea to remove the slash commands? I don't really see how can i use this commands in game , manys people prefere the GUI :p

For now, keep the long text. I'll deep dive into the Ace docs and see if there's a way to make that wrap. Or maybe I'll just move the common text "Hide the confirmation pop-up when" to a header, so each option becomes shorter.

A simple \n didn't work ?

I tested \n. It didn't wrap, it just truncated at the newline.

Maybe it would be a good idea to remove the slash commands? I don't really see how can i use this commands in game , manys people prefere the GUI :p

People use the slash commands in macros, so they can make a button to toggle a feature without having to open the config screen. I can't just remove them completely. It would break existing functionality for those users.

Would it be useful to localize the slash commands in French? I can make it support multiple key words for each command, like "loot" for English and "ramasse" in French, for example. So you could use /apr ramasse to toggle that first option. (I just picked a random word, you could put the correct words in the localization file and I could code to use it.)

We generally use English commands for slash commands, it's mostly for "advanced" users, so they know what they're doing, because honestly, I don't know why needed create a macro for a perennial option, since I've been using APR, I've never modified the options ^^.

So finally, the Texts are the same for the slash commands and for the GUI? isn't there a way of modifying them via a REGEX? instead of doubling the text just to change the color of a few words? :)

So finally, the Texts are the same for the slash commands and for the GUI? isn't there a way of modifying them via a REGEX? instead of doubling the text just to change the color of a few words? :)

Maybe ... but the regex would be different for every language. So either way it would have to be customized per language.

All right, I've finished the options revamp. You can see the result in v19.0.0-alpha4. For localization, there's a few new strings - *_name for each module. This is a couple of words that describe the option, and the long description that I used before is now under that name. When you're ready, you can update your pull request with a new localization file, and I can verify and close this out. :)

I'm working on a proof of concept build that breaks the option panel down into categories, and changes the layout a bit to allow for line wrapping. It will look something like this. The /apr whatever lines are a placeholder for now, until I come up with some better solution. Any ideas? Do you think this will be better?

The options changes are isolated in branch Options_Revamp. APR v19.0.0-alpha2 is building now. You can use that for testing.

The options changes are isolated in branch Options_Revamp. APR v19.0.0-alpha2 is building now. You can use that for testing.

Ok, I will try asap

APR 19.0.0-alpha3 has all the back-end changes in it. It shouldn't have any impact for you for localization compared to alpha2, but it has less bugs in it and is better for testing.

I like this new option mode =)

Can you give me details for this transaltion :

L["vendor_config"] = "Hide the confirmation pop-up when selling group-looted items to a vendor"

The context

Ok, all translations is done. you can merge =)

L["vendor_config"] = "Hide the confirmation pop-up when selling group-looted items to a vendor"

While in a group, you loot an item that is bind on pickup, but can be traded in the group. (For example, boss loot from a dungeon or raid, or loot from the chest in M+.) You then go to a vendor and try to sell that item while it is still tradable. This option makes the popup you get for that go away.

v19.0.0-alpha5 is building now; it should be ready in a few minutes. I'll leave it open for a day or two so we can review and test it, then push it live. Thank you again!

now need ru, pt, es, etc. :D

No problem, the hard work is done now! :) We just need someone who plays the game AND speaks the languages well enough to translate. :)

I'm still testing, but it seems I missed two strings. I've added them in commit 55646b4. These only appear in game if you type /apr with no parameters. I think you can just add to the same pull request, and I should be able to merge it in as well, but I'm not positive. This is new to me. :)

At first glance, everything else looks fine. I'll keep testing.

v19.0.0-release is packaging now and should be out shortly. Thank you again for the contribution! :)

v19.0.0-release is packaging now and should be out shortly. Thank you again for the contribution! :)

Love the 19.x :) good job