Sniper doesnt show any items if we have filter group with only base item ID idded.

Question

Sniper doesnt show any items if we have filter group with only base item ID idded.

FoiFoish opened this issue 5 years ago · 4 comments

FoiFoish commented 5 years ago

In new version sniper doesnt show any items if i try to search items that can have bonus id's. So instead a group with base id's there is necessary to create group with all possible variations of item.
Thank you for 8.3 update :)

Metric · Answer 1 · 2020-01-20T21:50:12.000Z

That is correct the final scan in a group is an exact scan on item id + bonus ids. Thus, you will need to include all bonus ids with the item id to have it show up in the final scan. The group scan is based on base id only. You do not need to include the base id in a filter if you provide the id + bonus ids. This only applies to equipment based scans. The bonus ids should be included in the sort order of low to high like in muffins list. Battle pet scan requires the pet species id + pet level + pet breed quality. I will need to add this information to the readme + curseforge and add in an option to disable exact item id bonus / pet level / pet breed matches on a filter.

…

On Mon, Jan 20, 2020 at 2:08 PM FoiFoish ***@***.***> wrote: Yes, i undesrtand that. Here is my example: a group with eternal palace cloak (i:168602) with filter ppu lt 500000g, when i click start there is "Gathering auctions" scan but there is no any result. But if I add available item with exact bonus, with exact filter (ppu lt 500000g) there is will be a result. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#11?email_source=notifications&email_token=AAB5I3LM3DKC6YMNRUJSV5LQ6YAE5A5CNFSM4KJI4WE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJNWJRA#issuecomment-576414916>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB5I3IF7RUDIILV6BD4W7DQ6YAE5ANCNFSM4KJI4WEQ> .

FoiFoish · Answer 2 · 2020-01-20T21:58:21.000Z

add in
an option to disable exact item id bonus / pet level / pet breed matches on
a filter.

That would be an ideal implementation. Thank you.

Metric · Answer 3 · 2020-01-20T19:53:09.000Z

I forgot to include in the readme, but I did post this info on reddit. Please up your max percent higher than necessary or create a custom filter to override the max percent. This is required, due to how it can only use the base id when checking the browse group for filtering price in tsm and tuj. If the base id group isn’t considered due to max percent then it will never scan the other higher ilevel / bonus ids in the final scan. As it skips over the browse groups based on that base id.

…

On Mon, Jan 20, 2020 at 1:29 PM FoiFoish ***@***.***> wrote: In new version sniper doesnt show any items if i try to search items that can have bonus id's. So instead a group with base id's there is necessary to create group with all possible variations of item. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#11?email_source=notifications&email_token=AAB5I3LMBY6KPNB4NCMILMLQ6X3RJA5CNFSM4KJI4WE2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IHOCQRQ>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB5I3J3HGMRUFXNFPEW6HDQ6X3RJANCNFSM4KJI4WEQ> .

FoiFoish · Answer 4 · 2020-01-20T20:08:45.000Z

Yes, i understand that. Here is my example: a group with eternal palace cloak (i:168602) with filter ppu lt 500000g, when i click start there is "Gathering auctions" scan but there is no any result. But if I add available item with exact bonus (i:168602::4:1517:1808:4786:4800 for example), with exact filter (ppu lt 500000g) there is will be a result.

Share to