Ara Broker Reputations

Ara Broker Reputations

43.2k Downloads

Renown Display issue

bubfeeld opened this issue ยท 7 comments

commented

I dont know why they cant leave well enough alone,lo

there seems to be a minor display issue with Renown,
they display like [Rep name] Renown %d [Renown level]

Im not sure but it seems this line (384)

local standingText = (RENOWN_LEVEL_LABEL .. data.renownLevel)

i thought maybe the <data.renownLevel> value was funky somehow
but its probably something else,lol

Image

commented

Believe it or not, it's coming from Blizzard this way. This constant "RENOWN_LEVEL_LABEL" is now including the %d. I'm doing some more research to see if this is a bug or intended. Stay tuned.

commented

figures, lol

I tried titan panels rep addons to see if they had the same issue, an older titan reputation (https://www.curseforge.com/wow/addons/titanrep)did the same thing, while newer one titan reputation continued (https://www.curseforge.com/wow/addons/titan-panel-reputation-continued) did not.

The newer one of those 2 didnt have the format of Renown [Renown level], it just has [Renown level]

Honestly my OCD likes the format how it has been with the text "Renown [Renown level]"

commented

if the goal is just the have the bar say Renown [Level], i was able to copy what another addon did for text, im sure its not very elegant and i dont know if its something that would break, but here:

i changed

local standingText = (RENOWN_LEVEL_LABEL .. data.renownLevel)

to

local standingText = ("Renown "..(data.renownLevel))

commented

Could do that, or wait for them to fix the constant. By using the constant, it helps the situation if they change the label to something else. Or if different reps have different labels down the road. Like sub-reps.

commented

right, its weird that they messed that up, but then again, ive ran into some really odd behavior lately, had an issue with my broker mail addon and the system reading mail where there was none, that they fixed.

btw , I truly appreciate any work and help you give, i could not say that enough

commented

Not error, just new format for string.format function. Just use standard approach:

local standingText = RENOWN_LEVEL_LABEL:format(data.renownLevel)

commented

Fixed in r87