The fixes you've done are quite frankly amazing, one small niggle is that when you minimise previous expansion reps, and gain any DF rep, all the minimised tabs are opened up again :D

Also, the historical reps have the + next to them, you have to click twice to minimise.

I think I can safely confirm, after a fair chunk of testing, that the datastore addon is causing the interference.

Ok, thanks. I'll take a look at that today. You're saying that all the reps have a "+" next to them when you gain DF rep after collapsing? I'll play around with it today and see if I can replicate.

This is what I'm seeing. Can you provide screenshots and some more info? Like what broker display are you using? Chocolate, Titan, other? Have you tried just this addon and the broker display? It appears to be working in my tests, unless I'm misunderstanding. What rep gain is causing this? Tuskar rep didn't seem to cause it.

I collapsed all previous headers, and left Shadowlands open. Gained rep, and they all stayed collapsed. Then I closed Shadowlands rep, and gained rep, they all stayed collapsed. I reopened Shadowlands rep at the end (4th screenshot) to see if anything was amiss.

So the "before" is with everything minim,ised, the "rep gain" shows a small rep gain to a DF faction and some older reps re-opneing with the + besdies them

I noticed it's when you move the mouse away anbd then back over the broker that it happens

Paragon rep gains are definitely borked in this scenario, I'll work on that. But I can't seem to replicate this scenario. Let me try to find some Valdrakken rep. I'm testing by raising Tuskarr, because it's simple to do, by turning in fish at the fish hole. I'm wondering if it's due to the fact that Valdrakken is a header as well that's breaking it. Try doing it on some other non header rep and see if it does the same thing for you.

It did it whith Tuskarr (cooking) and whatever rep you get from the Seige for me.

What broker display are you using? I don't recognize it and would like to test with it. Also, any other rep addons? It looks like something is messing with the IsCollapsed state of the reputation. This is actually saved as part of the GetFactionInfo(), which is a Blizzard function and not really something in code. I'll go through the code and see if I can find any issues, but it's hard to fix something I can't fully replicate.

I'll also play with it today with all my reps collapsed and see if anything comes out of it. If I can't find it, I may put some debugging lines in the code and post a new alpha so you can report back what it's doing.

Are you using the Sort By Reputation option by chance?

I use StatBlockCore as my broker addon, this is the only rep tracking addon I use however I likely have others that trrack rep in a hidden fasion (altoholic, for example)

I know it's a pain, but can you try disabling other addons except for this one and StatBlockCore just to eliminate any other interaction? I'll test with that broker myself today and I'll keep poking at it. I've put in some debugging code and so far it seems pretty stable maintaining the IsCollapsed state in my setup. If it is conflicting, if I know what it is conflicting with I can perhaps code around it.

Are you using the Sort by Reputation option by chance? It does look like the reps are sorted alphabetically in your screen shot, but I haven't fixed that code yet. I put that in the release notes. If you are using that, I'd turn it off for now. It's most likely very buggy and I have to go through that code yet. It's on my list for the beta release.

Ok, with only SBC and this enabled the rep tracking fine without the expansion of older reps however the double clicking of the + sign persists.

Edit: sort by reputation level is off

Ok, so something else is apparently messing with IsCollapsed() from GetFactionInfo(). I'm getting this state from the Blizzard call, and it is being saved per character in the config on exit and reloading. But it does always pull it when the table is updated. The button thing may be related to SBC, I'll load that up and see if I can replicate/fix that after maintenance is done today.

Ok, I've tracked it down. It looks like Datastore_reputations is the culprit, this is part of the Altoholic addon, with this off the expansion on rep gains goes away

Did it also fix the button issue?

Yes, it looks like both issues are related.

I'll download and take a look at it. But not sure it's something I can implement a fix for. I'm just pulling the state from the Blizzard function, so if that addon isn't respecting its state, then not sure what I can do.

I've put a comment on that addons's page, with a link to this chat, massive thanks in pinning it down!

I did find and fix the Paragon session gains for collapsed reps, I'll be pushing an update for that today.

Yeah, dug into Altoholic and the isCollapsed treatment. They're basically forcing open anything that isCollapsed, and then not restoring it to collapsed. Not quite sure why they're doing that, but that's not something I can deal with. They need to reset it back to the original state if they're changing it.

for i = GetNumFactions(), 1, -1 do		-- 1st pass, expand all categories
	local name, _, _, _, _, _, _,	_, isHeader, isCollapsed = GetFactionInfo(i)
	if isHeader then
		headerCount = headerCount + 1
		if isCollapsed then
			ExpandFactionHeader(i)
			headersState[headerCount] = true
		end
	end
end

Holy crap, nice detective work!! I've added this to my ticket on the altoholic page :)

What's happening is that I only update the tablet when a rep changes, so if Altoholic ignores user choice and expands everything, then isCollapsed is not in the same state that Ara knew it to be in when it last updated. Hence, when you get a rep update, things aren't the way it thought they were when it last updated and it's doing its best to get things back on track.

I could force it to update more, but that really shouldn't be needed, and that won't fix the crux of the problem is that Altoholic is ignoring user choice to collapse the rep in the first place.

The button thing is a bit of a problem with Ara. I'll work on fixing that as an issue. Because I can replicate it if I open the Blizzard rep panel and expand/collapse a header there, and then Ara doesn't have it in the right state. But keeping things collapsed is not going to work right if Altoholic is forcing everything open

Fixed the issue with the buttons, but again, honoring the collapsed state is something that Altoholic needs to stop changing unless the user wants it.