AtlasLootClassic

AtlasLootClassic

Addons
37M Downloads

Maps Missing

ramboozer opened this issue ยท 3 comments

commented

I noticed the data-tbc.lua was updated to including the newer dungeons / raids to have the maps within Atlas, I did this previously myself and it was working flawlessly. when I updated today I noticed you changed as I changed but it no longer is showing the maps at all.

Updated Today 6/6/2021
image

Old Version - I Hotfixed
image

This was done very fast and a few things were not typed correctly however they still worked (Talking about the map arrays) on my end

hotfix.zip

commented

Are you using the Atlas modules from curseforge?
https://www.curseforge.com/wow/addons/atlas-classicwow
https://www.curseforge.com/wow/addons/atlas-burningcrusade

Can confirm this fixed the missing maps for me at least (for both the classic maps and the tbc maps). I was using the AtlasLootClassic_Maps previously, without having atlas-classicwow or atlas-burningcrusade installed at all, and that got me the classic maps. But it stopped working recently. After installing the two classicwow and burningcrusade atlas addons the maps are all working, and I don't even need AtlasLootClassic_Maps anymore.

Looks like the tbc maps are relying on the Atlas_burningcrusade addon directly:
36e5a72#diff-964ea4aeaa6e2e6acdd6ffd19d372be5ab129dd2b2a7e90854e09699b37ad367R37

And as for the classic maps, the Atlas_ClassicWow addon is being directly used here now:
f611daf#diff-db2447604e52682444c4b6c4b5286149298aadcb691262f7449005adab2de771R45

Looks like there's code to say if you have the module it will get the maps from that, but if you don't, it should rely on AtlasLootClassic_Maps instead:
https://github.com/Hoizame/AtlasLootClassic/blob/master/AtlasLootClassic/GUI/GUI.lua#L474

But, seems like it may never get into the condition to use AtlasLootClassic_Maps, at least in my case (even without the Atlas_ClassicWow installed.) Or maybe it is hitting the condition, but the maps in AtlasLootClassic_Maps itself are no longer working? Or maybe the names of the map files it's looking for don't exist in AtlasLootClassic_Maps, because it seems like those changed as well in the code. I dunno, I didn't add any debugging or anything, just posting what I've noticed in game.

commented

The .atlasModules are hard coded to point at the Atlas modules. So AtlasMaps_GetMapPath in GUI.lua always looks for the Atlas module maps regardless of their actual presence.

Making a fork for this one suggestion seems like a bit much, but line 74 of GUI.lua could be a branch instead:

if IsMapsModuleAviable(nil) then
    GUI.frame.contentFrame.map.atlasMapModule = nil
else
    GUI.frame.contentFrame.map.atlasMapModule = moduleData[dataID].items[bossID].AtlasModule or moduleData[dataID].AtlasModule
end