Auctionator ClassicFix

Auctionator ClassicFix

2M Downloads

some error when open auction

SunnyJang38 opened this issue ยท 5 comments

commented

11:48 Interface\AddOns\Auctionator\Auctionator-100.0.8.lua:5076: bad argument #1 to 'strlen' (string expected, got nil)
11:48 [C]: in function strlen' Interface\AddOns\Auctionator\Auctionator-100.0.8.lua:5076: in function Atr_Item_Autocomplete'
[string ":OnCharComposition"]:1: in function <[string ":OnCharComposition"]:1>
11:48 (*temporary) = nil
(*temporary) = "string expected, got nil"

commented

that is a bit confusing arg1 variable seems to come from nowhere, maybe this is a copy paste or existing conversion error.

self:HighlightText(textlen - strlen(arg1), -1);

commented

it seems for languages with multiple keypress per character (like Japanese or Chinese) there was some attempt in code to handle autocomplete.

It appears to me that OnChar is perfect because it only returns when a new character (or string) has been inserted. We only need to perform autocomplete when this happens not when character composition is in progress. (i think).

so remove oncharcomposition all together and remove composition mode check... I can't really test this easily without changing my keyboard.

commented

i made changes here: bf0242f

commented

@SunnyJang38 you can confirm this fix works or not before i close issue?

commented

@SunnyJang38 you can confirm this fix works or not before i close issue?

yes, thanks for your work