Pets in favorite group, or loaded from favorite, do not show the actual breed in tooltip
tflo opened this issue · 4 comments
Issue
Example:
Option "Always show favorite group items, including when not in bag" is enabled.
- Add a level-1 P/S Iron Starlette to favorites (Selling tab).
- Have only a level-1 P/B Iron Starlette in the bags.
The quantity indicator of the fav icon in the Selling tab now shows "1" and it lets me load (select) the pet by clicking the fav icon. Both tooltips, the one from the favorite icon and the bigger icon after clicking the favorite show the pet as P/S, which is not the breed of the actual pet in bags (but the breed of the saved favorite):
The tooltip of the regular (non-fav) icon in the Selling tab shows the breed correctly:
If one is not aware of this behavior, then posting from the fav icon will lead to posting the wrong variant. This might seem trivial with the example pet, but there are pets where the breed makes a difference of several 100k gold.
To avoid errors, you must be aware of the issue and strictly only ever post from the "real" (in-bag) icon in the Selling tab, or from the bags directly.
Thinkable solutions:
- Make the favs strictly breed-specific (they are already level-specific):
- Counter shows "1" only if there really is one of that breed in the bags, and clicking the fav does not load a fictive variant for posting.
- Make the favs completely breed-agnostic (but not level-agnostic!):
- If I have one P/B and one P/S (of the same level) in my bags, the counter should show "2".
- The tooltip breed info of the fav icon should either be undefined (showing "??" if this is technically feasible, no idea), or should show just the breed of any of the variants actually present in the bags.
- After loading (clicking) the fav for posting, the main icon (of the loaded pet) should show the actual breed of the loaded variant that is going to be posted.1
I tend to prefer solution 2 (breed-agnostic), as it can save quite some space in the fav compartment. And if the tooltip of the loaded pet icon is correct, then it is possible to reliably post the correct variant.
Footnotes
-
If I remember correctly, this was the case with some previous version of Auctionator (like some months ago). But not 100% sure, memory may fail. ↩
Fixed in the latest alphas (available from CF and Wago when they finish processing)
Yes, now the pet that is loaded (shown in the big icon field) is actually the breed that gets posted. This is good.
But now, when I load a pet directly from the bags (Alt-Left-click) into Auctionator, it doesn't load the one I've clicked, instead it always takes the one that comes first in the bag. This is reproducible.
Example:
I have these breeds of the same pet in the bags:
When I Alt-click the PB or PS, Auctionator loads the SS. If I move the PS to first position, then it takes always the PS, etc.
(Just to be sure, I unloaded Baganator and tried with Blizz's bags, but it's the same.)
PS: Auctionator 10.2.25-2-gc97017f on Retail
PS2: It is OK that it takes any breed if I load from the Selling tab, since I only have one icon for all breeds there (as long as the link in the big icon field shows the one that gets posted), but picking from the bags should take the clicked one, IMHO.