7.3 issue - sound related (?)
Hazblade opened this issue · 14 comments
Hey buddy. Firstly thanks for the addon. Been using it forever.
Here's an error capture for the 7.3 error. They updated the sound library. Bunch of addons having similar issues. http://imgur.com/kjZxxy5
I'm gonna replace the sound with a random working one for now.
It's just this user @gmail. I think my github account might be too new or something. I can't seem to be able to PM or create new branches and stuff like that. Had me a bit confused earlier
Shoot. Can you do a PR? I won't be home until like midnight (PST) tonight to be able to release a new version.
Yeah I had to step out for a bit but I'll do it as soon as I get back to the keyboard
I appreciate it! Once a PR is approved, the build scripts will generate a release that we can test (though I don't have any testers hanging out in the slack room ATM), and I can probably release from the office. :)
It's super dirty and still errors in the bg but functionality is 100% as far as I can tell
I'm a fan of the standard OSS model: fork and PR from fork. I like branch names that start with the ticket number just so stuff is easy to track. 😄
Lol I glanced at it and I'm honestly not sure. 😛 Did I have changes I hadn't merged into master for a previous update? Or did you update the dependencies, too?
That's about where my knowledge ends. I just updated the auctionator.lua file and pasted that
Also @Hazblade if you PM me your email address, I can invite you to the Auctionator slack channel. It's not terribly exciting, but it's where the builds get dropped, and it's a little easier to get my attention there. :)
@Hazblade Would you mind posting your Auctionator.lua into something like pastebin.com and then posting the link here? Pasting it in the conversation of a pull request mangled the text.