Auctionator bug
badimus opened this issue · 9 comments
Occasionally I get a conflict when using the default UI to queue for bgs
Date: 2016-01-30 21:32:58
ID: 1
Error occured in: AddOn: Auctionator
Count: 1
Message: Error: AddOn Auctionator attempted to call a forbidden function (JoinBattlefield()) from a tainted execution path.
Debug:
Blizzard_PVPUI\Blizzard_PVPUI.lua:524: HonorFrame_Queue()
[string "*:OnClick"]:1
Locals:
None
AddOns:
Swatter, v5.0.0 (<%codename%>)
NPCScan, v6.2.3.6
NPCScanOverlay, v6.2.3.1
AtlasLoot, vv8.00.60
Auctionator, v3.2.6
AutoRepair, v
Babylonian, v5.1.DEV.332(/embedded)
Bartender4, v4.6.12
Capping, v6.2.01
Configator, v5.1.DEV.376(/embedded)
Coordinates, v1.19
CrapAway, v
Gatherer, v5.0.0
HandyNotes, vv1.4.6
HandyNotesDraenorTreasures, v1.16
HealersHaveToDie, v2.3.7
PetTracker, v6.2.5
PetTrackerBreeds, v
PetTrackerConfig, v
PetTrackerSwitcher, v
PetTrackerUpgrades, v
Postal, v3.5.4
Recount, vv6.2.3e release
SlideBar, v5.0.0 (<%codename%>)
TomTom, vv60200-2.1.0
BlizRuntimeLib_enUS v6.2.3.60200
(ck=28f)
Not an auctionator bug. We don't hook any Bg or queue functions. this is caused by taint form another addon and is caught by auctionator. May want to look at addons specific to battlegrounds like capping.
This is still happening with only Auctionator 4.0.19 loaded on build 7.3.5.26365
https://streamable.com/uyflg
You can use LibUIDropDownMenu, but it might be fixed in BfA
https://www.townlong-yak.com/bugs/afKy4k-HonorFrameLoadTaint
@Ketho I can't reproduce with current version of Auctionator following the steps in your stream, can you still repro with 5.0.1?
Use reproduction steps from foxlit research as fix might be already injected by other addon.
This taint is elusive but Auctionator is definitely affected.
I disabled all but Auctionator. Foxlit research?
I was going to load the patch suggested by the link above first, but wanted to verify nothing goes wrong if I do... Not being able to reproduce it, though, I'm not sure how to verify I haven't broken something else. 😄
@AcidWeb Is this reproducable for you? If so, I can give you a zip with the updated code to test?
Many big players like ElvUI already include this snippet so it is 100% safe. I also use it in my addons.
No need for ZIP - I know it is a valid fix.