Aurora

Aurora

352k Downloads

[Bug] SharedXML and FrameXML (SharedUIPanelTemplates.lua issues)

Prism0Github opened this issue ยท 0 comments

commented

Is there an existing issue for this?

  • I have searched the existing issues

Game Client

WotLK Classic

Current Behavior

I'm not that much of a lua expert to know what exactly is going on but there seems to be multiple issues with the "SharedUIPanelTemplates.lua" file, namely:

  1. Attempting to index a nil value called "Frame" at line 565 (Ignore the "@MoveAnything" errors since that results only due to said addon creating a new button in the standard Game Menu which doesn't neccessarily need to be skinned by Aurora)
  2. A "function" hook error at line 46 in the file "skin.lua" resulting in more "SharedUIPanelTemplates.lua" errors

BugSack error code for 1. is as follows:
2x ...\Skin\SharedXML\SharedUIPanelTemplates.lua:565: attempt to index local 'Frame' (a nil value) [string "@Aurora\Skin\SharedXML\SharedUIPanelTemplates.lua"]:565: in function NineSlicePanelTemplate'
[string "@aurora\Skin\SharedXML\SharedTooltipTemplates.lua"]:32: in function `TooltipBackdropTemplate'
[string "@MoveAnything\Libs\MSA-DropDownMenu-1.0\MSA-DropDownMenu-1.0-11.lua"]:1684: in function <...g\Libs\MSA-DropDownMenu-1.0\MSA-DropDownMenu-1.0.lua:1680>
[string "@MoveAnything\Libs\MSA-DropDownMenu-1.0\MSA-DropDownMenu-1.0-11.lua"]:1694: in function <...g\Libs\MSA-DropDownMenu-1.0\MSA-DropDownMenu-1.0.lua:1691>

Locals:
Frame = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index local 'Frame' (a nil value)"
Hook =

{
MerchantFrame_UpdateCurrencies = defined @aurora\Skin\Interface_TBC\FrameXML\MerchantFrame.lua:19
QuestInfo_GetRewardButton = defined @aurora\Skin\Interface_Wrath\FrameXML\QuestInfo.lua:67
MovieFrameCloseDialog_OnShow = defined @aurora\Skin\FrameXML\MovieFrame.lua:12
BonusRollFrame_OnShow = defined @aurora\Skin\FrameXML\LootFrame.lua:83
ChatBubble_SetName = defined @aurora\Skin\init.lua:90
QuestFrameProgressItems_Update = defined @aurora\Skin\Interface_Wrath\FrameXML\QuestFrame.lua:13
SetItemButtonQuality = defined @aurora\Skin\FrameXML\ItemButtonTemplate.lua:14
CraftFrame_Update = defined @aurora\Skin\Interface_WrathBlizzard_CraftUI.lua:15
SpellBookFrame_UpdateSkillLineTabs = defined @aurora\Skin\FrameXML\SpellBookFrame.lua:29
AudioOptionsVoicePanel_InitializeCommunicationModeUI = defined @aurora\Skin\FrameXML\AudioOptionsPanels.lua:13
PaperDollFrame_SetLevel = defined @aurora\Skin\Interface_Wrath\FrameXML\PaperDollFrame.lua:13
AuctionFrameBrowse_Update = defined @aurora\Skin\Interface_WrathBlizzard_AuctionUI.lua:44
ChannelButtonHeaderMixin =
{
}
ClassTrainer_SetToClassTrainer = defined @aurora\SkinBlizzard_TrainerUI.lua:65
UpdateMicroButtons = defined @aurora\Skin\Interface_Wrath\FrameXML\MainMenuBarMicroButtons.lua:63
UIDropDownMenu_SetWidth = defined @aurora\Skin\FrameXML\UIDropDownMenu.lua:116
ClassTrainer_SetToTradeSkillTrainer = defined @aurora\SkinBlizzard_TrainerUI.lua:60
EmbeddedItemTooltip_PrepareForSpell = defined @aurora\Skin\FrameXML\GameTooltip.lua:24
ClassTrainer_SetSelection = defined @aurora\SkinBlizzard_TrainerUI.lua:51
NavBar_CheckLength = defined @aurora\Skin\FrameXML\NavigationBar.lua:17
ContainerFrameFilterIcon_SetAtlas = defined @aurora\Skin\FrameXML\ContainerFrame.lua:19
ClassTrainerFrame_Update = defined @aurora\SkinBlizzard_TrainerUI.lua:15
TradeSkillFrame_SetSelection = defined @aurora\Skin\Interface_WrathBlizzard_TradeSkillUI.lua:51
TradeSkillFrame_Update = defined @aurora\Skin\Interface_WrathBlizzard_TradeSkillUI.lua:15
ReputationFrame_Update = defined @aurora\Skin\Interface_Wrath\FrameXML\ReputationFrame.lua:18
ObjectPoolMixin =
{
}
RaidGroupFrame_Update = defined @aurora\Skin\Interface_WrathBlizzard_RaidUI.lua:14
MacroFrame_OnShow = defined @aurora\SkinBlizzard_MacroUI.lua:14
LFGFrameMixin =
{
}
ChatConfig_CreateCheckboxes = defined @aurora\Skin\FrameXML\ChatConfigFrame.lua:14
PaperDollItemSlotButton_Update = defined @aurora\Skin\Interface_Wrath\FrameXML\PaperDollFrame.lua:17
AuctionSellItemButton_OnEvent = defined @aurora\Skin\Interface_WrathBlizzard_AuctionUI.lua:80
QuestFrame_SetTextColor = defined @aurora\Skin\Interface_Wrath\FrameXML\QuestFrame.lua:74
QuestFrame_ShowQuestPortrait = defined @aurora\Skin\Interface_Wrath\FrameXML\QuestFrame.`

BugSack error code for 2. is as follows:
1x Aurora\Skin\skin.lua:46: Usage: hooksecurefunc([table,] "function", hookfunc) [string "=[C]"]: in function hooksecurefunc'
[string "@aurora\Skin\skin.lua"]:46: in function <Aurora\Skin\skin.lua:45>
[string "=[C]"]: in function FrameTypeButton' [string "@Aurora\Skin\SharedXML\SecureUIPanelTemplates.lua"]:112: in function UIPanelButtonNoTooltipTemplate'
[string "@aurora\Skin\SharedXML\SharedUIPanelTemplates.lua"]:266: in function UIPanelButtonTemplate' [string "@Aurora\Skin\Interface_WrathBlizzard_InspectUI.lua"]:147: in function addonModule'
[string "@aurora\Skin\init.lua"]:274: in function <Aurora\Skin\init.lua:238>
[string "=[C]"]: in function LoadAddOn' [string "@Interface_Wrath\FrameXML\UIParent.lua"]:385: in function UIParentLoadAddOn'
[string "@Interface_Wrath\FrameXML\UIParent.lua"]:428: in function InspectFrame_LoadUI' [string "@Interface_Wrath\FrameXML\UIParent.lua"]:733: in function InspectUnit'
[string "@FrameXML\UnitPopupSharedButtonMixins.lua"]:200: in function OnClick' [string "@FrameXML\UnitPopupShared.lua"]:148: in function func'
[string "@FrameXML\UIDropDownMenu.lua"]:944: in function `UIDropDownMenuButton_OnClick'
[string ":OnClick"]:1: in function <[string ":OnClick"]:1>
[string "=[C]"]: ?

Locals:
(*temporary) =

{
ContainerFrame5Item7 = ContainerFrame5Item7 {
}
DH_HAVOC_CORE_ABILITY_2 = "Strong melee attack that consumes Fury. If it critical strikes, some Fury is refunded."
BT4Button85Shine14 = BT4Button85Shine14 {
}
GetTrainerServiceTypeFilter = defined =[C]:-1
UNIT_NAMES_COMBATLOG_TOOLTIP = "Color unit names."
AchievementFrameStatsBG = AchievementFrameStatsBG {
}
SetTrainerServiceTypeFilter = defined =[C]:-1
LE_GAME_ERR_CHAT_RAID_RESTRICTED_TRIAL = 788
SPELL_FAILED_CUSTOM_ERROR_71 = "This partygoer wants to dance with you."
LE_GAME_ERR_PET_SPELL_TARGETS_DEAD = 406
BT4Button58 = BT4Button58 {
}
CompactUnitFrameProfilesGeneralOptionsFrameHealthTextDropdownButtonNormalTexture = CompactUnitFrameProfilesGeneralOptionsFrameHealthTextDropdownButtonNormalTexture {
}
InspectFrameTab1HighlightTexture = InspectFrameTab1HighlightTexture {
}
PawnItemComparer = defined @Pawn\Pawn.lua:4032
MultiBarLeftButton7 = MultiBarLeftButton7 {
}
AudioOptionsVoicePanelOutputDeviceDropdownButtonHighlightTexture = AudioOptionsVoicePanelOutputDeviceDropdownButtonHighlightTexture {
}
LE_GAME_ERR_INVALID_FOLLOW_PVP_COMBAT = 359
MerchantItem3AltCurrencyFrameItem1Text = MerchantItem3AltCurrencyFrameItem1Text {
}
BINDING_NAME_NAMEPLATES = "Show Enemy Name Plates"
INSTANCE_UNAVAILABLE_OTHER_TEMPORARILY_DISABLED = "%s cannot enter. This instance is temporarily disabled."
EncounterDetails_SpellAurasScrollScrollChildFrame = EncounterDetails_SpellAurasScrollScrollChildFrame {
}
MultiBarBottomRightButton8Shine5 = MultiBarBottomRightButton8Shine5 {
}
IsReferAFriendLinked = defined =[C]:-1
UnitFrameManaBar_UnregisterDefaultEvents = defined @FrameXML\UnitFrame.lua:603
CALENDAR_RAID_RESET_DESCRIPTION = "%1$s resets at %2$s."
CraftExpandTabLeft = CraftExpandTabLeft {
}
BT4Button22Flash = BT4Button22Flash {
}
AchievementFrameStatsContainerButton8HeaderMiddle = AchievementFrameStatsContainerButton8HeaderMiddle {
}
WatchFrameItem_OnEvent = defined @Interface_Wrath\FrameXML\WatchFrame.lua:1183
CompactRaidFrameManagerDisplayFrameHiddenModeToggleTopRight = CompactRaidFrameManagerDisplayFrameHiddenModeToggleTopRight {
}
LE_GAME_ERR_ONLY_ONE_QUIVER = 32
INT_SPELL_DURATION_HOURS = "%d |4hour:hrs;"
LOSS_OF_CONTROL_DISPLAY_FEAR = "Feared"
Graphics_QualityText = Graphics_QualityText {
}
OverrideActionBarButton6Shine11 = OverrideActionBarButton6Shine11 {
}
CompactUnitFrameProfilesSaveButton = CompactUnitFrameProfilesSaveButton {
}
AUCTIONATOR_L_DEFAULT_LIST_HEADER = "Default Shopping List"
RaidGraphics_EnvironmentalDetailSlider = RaidGraphics_EnvironmentalDetailSlider {
}
PetPaperDollFrameTab3Right = PetPaperDollFrameTab3Right {
}
Is64BitClient = defined =[C]:-1
CompactRaidFrameManagerDisplayFrameFilterOptionsFilterRoleTankMiddleMiddle = CompactRaidFrameManagerDisplayFrameFilterOptionsFilterRoleTankMiddleMiddle {
}
SortQuestWatches = defined =[C]:-1
ContainerFrame4Item16Cooldown = ContainerFrame4Item16Cooldown {
}
DUNGEON_FLOOR_DRAGONBLIGHTCHROMIESCENARIO2 = "Andorhal"
AchievementFrameComparisonContainerButton7FriendShield = AchievementFrameComparisonContainerButton7FriendShield {
}
PlayerFrame_UpdateReadyCheck = defined @FrameXML\PlayerFrame.lua:360
WowTokenRedemptionFrameBg = WowTokenRedemptionFrameBg {
}
Questie_ItemButton24Shine13 = Questie_ItemButton24Shine13 {
}
SPELL_FAILED_CUSTOM_ERROR_152 = "You must choose a specialization to use Ascendance."
LAG_TOLERANCE = "Lag Tolerance"
GuildControlPopupFrame = GuildControlPopupFrame {
}
NamePlate9PlaterUnitFrame = NamePlate9PlaterUnitFrame {
}
SendStationeryBackgroundRight = SendStationeryBackgroundRight {
}
TUTORIAL61_SPELLID_DRUID = "768"
AUCTIONATOR_L_HIDE = "Hide"
MultiBarLeftButton9Border = MultiBarLeftButton9Border {
}
LE_GAME_ERR_NOT_ON_TOURNAMENT_REALM = 880
BT4Button13Name = BT4Button13Name {
}
PlayerTalentFrameBranch17 = PlayerTalentFrameBranch17 {
}
OPTION_TOOLTIP_SHOW_ACCOUNT_AC`

I'm sorry if I made any mistake in explaining the issue and if I need to open 2 issues because these are 2 separate issues (stemming from the same file), please don't be shy and go ahead telling me. I have never opened an issue on Github so I'm not quite sure how this exactly works or should be handled.

Cheers.

Expected Behavior

I cannot precisely say what the expected addon behaviour should be since I'm too bad at lua to decipher what exactly the problem is within the code I previously posted. It might be an addon conflict but I couldn't deduct that from the error code.

However, if I am in any instanced zone whatsoever, the Aurora support for the chat bubbles breaks which probably has to do with the error code I posted above. I cannot currently think of any other obvious or visible visual errors with any frames, but some of those might be hidden since my UI is extremely customized.

The latter error with chat bubbles might be somewhat unrelated in terms of when it happens because both of the posted errors happen outside of instances and entering instances does not create additional lua errors.

Steps To Reproduce

  1. Entering any instance
  2. Observing chat bubbles reverting to their default Blizzard look (textures, font, scale etc.)

Additional context

No response