Aurora

Aurora

352k Downloads

[Bug] Error looting in party

Jeremy7600 opened this issue ยท 1 comments

commented

Is there an existing issue for this?

  • I have searched the existing issues

Game Client

Wrath Classic

Current Behavior

1394x ...ddOns\Aurora\Skin\FrameXML\LootHistory.lua:25: attempt to call field 'CropIcon' (a nil value)
[string "@aurora\Skin\FrameXML\LootHistory.lua"]:25: in function <...ddOns\Aurora\Skin\FrameXML\LootHistory.lua:13>
[string "=[C]"]: ?
[string "=[C]"]: in function LootHistoryFrame_UpdateItemFrame' [string "@FrameXML\LootHistory.lua"]:68: in function LootHistoryFrame_FullUpdate'
[string "@FrameXML\LootHistory.lua"]:28: in function <FrameXML\LootHistory.lua:26>

Locals:
self = LootHistoryFrame {
0 =
unusedPlayerFrames =

{
}
Divider = {
}
Label = {
}
usedPlayerFrames =
{
}
layoutType = "TooltipDefaultLayout"
GetBackdropColor = defined @SharedXML\SharedTooltipTemplates.lua:191
highlightedRolls =
{
}
SetBackdropBorderColor = defined @SharedXML\SharedTooltipTemplates.lua:195
expandedRolls =
{
}
ScrollFrame = LootHistoryFrameScrollFrame {
}
NineSlice = {
}
backdropColorAlpha = 0.800000
TooltipBackdropOnLoad = defined @SharedXML\SharedTooltipTemplates.lua:172
itemFrames =
{
}
GetBackdropBorderColor = defined @SharedXML\SharedTooltipTemplates.lua:199
SetBorderBlendMode = defined @SharedXML\SharedTooltipTemplates.lua:203
ResizeButton = {
}
DragButton = {
}
SetBackdropColor = defined @SharedXML\SharedTooltipTemplates.lua:187
CloseButton = {
}
LootIcon = {
}
}
frame = {
0 =
ItemName = {
}
Divider = {
}
itemIdx = 1
NameBorderRight = {
}
itemLink = "|cff1eff00|Hitem:36051::::::-38:410452046:80:::::::::|h[Vizier Sash of the Prophet]|h|r"
NameBorderMid = {
}
rollID = 1
ActiveHighlight = {
}
ToggleButton = {
}
WinnerName = {
}
IconBorder = {
}
WinnerRollType = {
}
WinnerRoll = {
}
Icon = {
}
NameBorderLeft = {
}
}
rollID = 1
_ = "|cff1eff00|Hitem:36051::::::-38:410452046:80:::::::::|h[Vizier Sash of the Prophet]|h|r"
_ = 5
isDone = false
winnerIdx = nil
expanded = nil
(*temporary) = nil
(*temporary) = {
0 =
}
(*temporary) = {
0 =
ItemName = {
}
Divider = {
}
itemIdx = 1
NameBorderRight = {
}
itemLink = "|cff1eff00|Hitem:36051::::::-38:410452046:80:::::::::|h[Vizier Sash of the Prophet]|h|r"
NameBorderMid = {
}
rollID = 1
ActiveHighlight = {
}
ToggleButton = {
}
WinnerName = {
}
IconBorder = {
}
WinnerRollType = {
}
WinnerRoll = {
}
Icon = {
}
NameBorderLeft = {
}
}
(*temporary) = "attempt to call field 'CropIcon' (a nil value)"
Skin =
{
ExpandOrCollapse = defined @aurora\Skin\SharedXML\SharedUIPanelTemplates.lua:48
HorizontalBarTemplate = defined @aurora\Skin\FrameXML\UIPanelTemplates.lua:149
GossipFramePanelTemplate = defined @aurora\Skin\FrameXML\GossipFrame.lua:62
InputScrollFrameTemplate = defined @aurora\Skin\SharedXML\SecureUIPanelTemplates.lua:72
PopupButtonTemplate = defined @aurora\Skin\FrameXML\ItemButtonTemplate.lua:72
UIPanelButtonNoTooltipTemplate = defined @aurora\Skin\SharedXML\SecureUIPanelTemplates.lua:111
CommunitiesSettingsButtonTemplate = defined @aurora\SkinBlizzard_Communities.lua:232
TooltipBorderedFrameTemplate = defined @aurora\Skin\SharedXML\SharedTooltipTemplates.lua:40
UnitPopupVoiceToggleButtonTemplate = defined @aurora\Skin\FrameXML\UnitPopupCustomControls.lua:15
InputBoxInstructionsTemplate = defined @aurora\Skin\SharedXML\SharedUIPanelTemplates.lua:501
OptionsListButtonTemplate = defined @aurora\Skin\FrameXML\OptionsFrameTemplates.lua:29
MoneyInputFrameTemplate = defined @aurora\Skin\FrameXML\MoneyInputFrame.lua:16
HybridScrollBarTemplate = defined @aurora\Skin\SharedXML\HybridScrollFrame.lua:45
TradeSkillItemTemplate = <func

Expected Behavior

No error

Steps To Reproduce

Join a party
When loot drops that is rolled on, the error occurs.

Additional context

No response

commented

It appears that the function calls a .CropIcon method that doesn't exist in Skin, only in Base.

So I added the "local Base = Aurora.Base" to the top of the Skin\Interface\FrameXML\LootHistory.lua and then changed line 25(now 26) to read "frame.bg = Base.CropIcon(frame.Icon, frame)"

I found this by looking for CropIcon in the files and seeing every other mention of it in the form Base.CropIcon except for the LootHistory.

No longer getting the error after this change.