Auto Potion

Auto Potion

282k Downloads

Addon is overwriting the global Item table in-game

Hekili opened this issue ยท 3 comments

commented

The Item table in WoW is used for loading and validating items for testing purposes. Your latest version of the addon overwrites the existing global table with a blank table before adding elements, here:

https://github.com/ollidiemaus/healthstoneAutoMacro/blob/main/Core/Item.lua#L1

I would recommend using a different able name or keeping your addon tables within your addon's namespace instead. Otherwise, this will break all other addons that use the Item table and/or taint the base UI when it looks for those item functions.

commented

A large number of my addons broke after this update for this reason. Disabling/rolling back fixed it.

commented

Thanks.
Yeah that was my bad I'll fix it.

commented

Okay turns out I just keep using my own namespace might be the best idea.
Don't wanna mess with any other addons.
Thanks for the Feedback anyways :)