aux

aux

1M Downloads

Hook issue

sipertruk opened this issue ยท 7 comments

commented

You're doing tooltip:Show() on frames you didn't create (tooltip.lua line 117).
It is the role of the creator to do that.
This is causing duplicate processing issues when an addon hooks the show function (Questie).

commented

Eh what? Those tooltips are blizzard frames. It's not their role to do anything anymore. The issue with questie was fixed here probably: Questie/Questie#334 (comment)

commented

If I remove that line aux is working exactly the same, or please tell me what i am missing.

commented

Don't remember but I don't call functions for no reason. May have something to do with the money for sell values when at a vendor.

commented

Useful only if you added a line in the tooltip in fact. Questie was bogus alright.

commented

Well, I am adding lines to the tooltip there no? Maybe it was about resizing the tooltip frame? I also vaguely remember something about wanting to move the icon-goldvalue when at a vendor below aux' added lines which required some weird code. Anyway, I hate superfluous code so if it's not obvious something is needed I probably tested to make sure it is.

commented

Not always, it's not adding lines if options are disabled or for quest items unless for rare tradable ones.
I would check tooltip:NumLines() and tooltip:Show() only if needed, but it sure is your call.

commented

Oh, yeah, i guess. Actually there was no option to disable the historical value at first. Either way, I don't see the harm in always calling it. It's less code and no noticeable difference in performance.