Smart Sorting
srtzero opened this issue · 26 comments
Is your feature request related to a problem? Please describe.
Currently using the sort button in classic just moves all items and fills in empty bag slots, but does not put similar items together.
Describe the solution you'd like
Would like to see smart sorting using Item rulesets. For example, all food related items, all armor, etc.... are placed next to each other when filling in empty bag slots.
Describe alternatives you've considered
Currently I have no other options to run any type of item ruleset sorting.
Additional context
Add any other context or screenshots about the feature request here.
(sorry I missed the screenshots as they didn't load on my phone). Yeah I'll add an option to modify the sorting start point.
This is how it should look after sorting
This is how it currently looks after sorting.
This still sorts super weird. Why does it use the middle as the starting point for sorting? Even doing left/right click on the sort button makes it weird. Can we pick our own point for sorting? I prefer it to start in the bottom right corner, as it makes the most sense to me.
What sort method are you using?
Quality type, which is what I was wanting, but the location that it starts the sorting is odd.
The sort options will be reworked at some point to offer more customisability and match more use cases.
Try this build, and turn both the new options on and then left-click the sort button:
This was brought up to him a couple times on his reddit thread. It's something he said he would look into. Depending on how much work it would take to implement, he could do it soon. The example given was how ELVUI sorts. For Retail I mean, but it would make sense for it to apply to both.
Status update, working on formula to decide what order the items should be in (don't have combining stacks yet or applying the sort to a live bag)
^^ that's by quality and then by item type
^^ reverse
^^ by item type and then quality
Thats awesome. Pretty much what I was hoping for. Thank you for the hard work your putting into your addon. Just one minor thing, seems since the last update the option to show the sort button in WoTLK has disappeared.
Incomplete, but will move around the items so like is next to like and some kind of order is in place. Notably it doesn't combine stacks yet.
Configure the sorting method in the Windows section of the options:
Will turn (in quality mode):
into:
Going to post versions here as they're ready. This one includes a bugfix for a case where the sorting wouldn't complete:
Baganator-0.58-3-g671df55.zip
Edit 1:
Another bugfix
Baganator-0.58-3-g671df55.zip
Edit 2:
Bugfixes and code cleanup
Baganator-0.58-5-g46c4180.zip
So the option to show the sort button is there, but the button does not show on the UI. I'm using the Baganator-0.58-5-g46c4180.zip
Fixed (still had some leftover code from before it was native)
Baganator-0.58-10-g0475f63.zip
Updated version. This edition will combine any incomplete stacks alongside other fixes and improvements:
Baganator-0.59-14-g8ae08c3.zip
So the option to show the sort button is there, but the button does not show on the UI. I'm using the Baganator-0.58-5-g46c4180.zip
Hmm, I used that one, and had no issues with the sort button.
Fixed (still had some leftover code from before it was native) Baganator-0.58-10-g0475f63.zip
This is close though. Is it possibly to combine type and quality into one? Doesn't make much sense to separate them. You end up with gear far away from each other. This is one of the things I like about Elvui's sort so much.
Updated version, now supports different types of bags and is more robust.
Baganator-0.59-13-g23e4630.zip
The sorts are pretty similar, any both use a mix of type and quality, just prioritising one or the other. You can find the sort priorities in Sorting/Main.lua - try swapping around the terms (but always leave index at the end - otherwise you may have bugs when sorting):
local QualityKeys = {
"quality",
"classID",
"subClassID",
"itemID",
"itemLink",
"itemCount",
"index",
}
local TypeKeys = {
"classID",
"subClassID",
"itemID",
"quality",
"itemID",
"itemLink",
"itemCount",
"index",
}New version, this should be the last one (assuming no bugs) before releasing the sort to alpha:
Add custom sort algorithms for by item type and by item quality
Will sort the entire bank, including reagent bank and it will move any
reagents in the regular bank to any empty slots in the reagent bank.Special bags (herbalism/inscription/etc) are supported.
Hearthstones are sorted first
Also permits changing the sort algorithm to the Blizzard one (retail)
and to SortBags (classic)
New version, this should be the last one (assuming no bugs) before releasing the sort to alpha:
Add custom sort algorithms for by item type and by item quality
Will sort the entire bank, including reagent bank and it will move any
reagents in the regular bank to any empty slots in the reagent bank.
Special bags (herbalism/inscription/etc) are supported.
Hearthstones are sorted first
Also permits changing the sort algorithm to the Blizzard one (retail)
and to SortBags (classic)
What do you mean by changing the sort algorithm to SortBags? I thought since its native on Baganator we didnt need the Sortbags addon.
- as I've added the Blizzard version as an option to retail it felt like it made sense to have an option that was similar on classic
(also, if a user doesn't have sortbags installed they won't even see it as an option)
(also, if a user doesn't have sortbags installed they won't even see it as an option)
That makes sense. Cool.
I like the new sort icon and the fact there is now a sorting tab in the settings. Much easier to find and enable the sorting options.
The only thing I might suggest is the new icon looks like its sitting all the way up on the red backdrop. Maybe bring it down a bit so it looks centered?
I've moved the sorting code into the latest alpha now, which will be available from Curseforge shortly.
The icon is awkward to adjust as it has its own background as well as the red background for the button (its a Blizzard texture), so any alignment will look a bit off.