Baganator

Baganator

1M Downloads

'uncollected' keyword not working on armor?

Jahfry opened this issue · 22 comments

commented

Brief Description of Bug

  • Using current Baganator on Curseforge
  • With a rule defined with 'Search' as 'uncollected'
    • Weapons (3 guns) show up as expected in the 'Uncollected' category
    • Armor (1 Head) does not show up as expected
    • Screenshot attached
      • The character viewing these bags is a DH, and so can't use any of them (ie, can't equip the gun weapons or mail armor)
      • When right-clicking any of these items I am prompted that they will be collected and made Warbound until equipped by a different character

I don't know if this issue existed prior to 11.0 as I'm a new Baganator user. I could see how maybe this was expected behavior prior to 11.0 if Baganator was assuming that I couldn't equip the mail armor, however that would still have been weird as the Mail armor piece is still BoE so I could have mailed it to an alt to equip.

Steps to Reproduce

(see above description and screenshot here)
baganator bug uncollected

Loaded Addons

AllTheThings
Auctionator
BigWigs
BlizzMove
BtWLoadouts
BugGrabber
BugSack
CraftSim
Details
Dominos
Dragon Rider
GTFO
HidingBar
LittleWigs
Macro Toolkit
Manuscripts Journal
Masque
Method Raid Tools
Narcissus
NoAutoClose
PasteNG
Pawn
Plater
Plumber
Prat 3.0
Raider.IO
SharedMedia
Simple Item Level
Simulationcraft
Syndicator
Talent Tree Tweaks
TomTom
Trade Skill Flux Capacitor
Trove Tally
True Stat Values
Vendor
Wago App Companion
WeakAuras
WorldBossTimers

commented

There's an issue with the Blizzard APIs Syndicator uses to track collected status not returning correct values since the Warband change.

commented

Note: to test I tried removing the Armor category, no change on appearing in Uncollected (just move all Armor to Other)

commented

Some follow-up notes ...

  1. The character in the initial screenshot is a L70 DH with Engineering. Definitely should have been able to equip.
  2. I transferred the item to my bank toon, which is an L1 Rogue without Engineering. Definitely not able to equip. Armor item still didn't sort into my "Uncollected" category
  3. I'm using "All the Things" which adds tags I can see on hover for 'Collected' / 'Not Collected' (as shown in screenshot) and 'Future Warband Collected' (needs to be clicked and made Warbound to be made collected).
  4. I disabled All the Things and reloaded to make sure that wasn't causing a conflict, no change.
  5. I have another Engineering optics item ('Quality-Assured Optics', cloth goggles) in inventory that also isn't sorting properly.

I haven't been able to find others doing the same behavior (yet?). I'm unsure if maybe the Engineering requirement is related to the problem (again, with a character that meets the requirement) or if that is a red herring.

I've spammed you with a fair number of feature requests, so I hope I'm not overloading you. This bug is more important to me for figuring it out than the requests right now as this actually interferes with collecting/selling.

commented

Do you have the "Completionist" setting enabled in ATT, as it looks like you're trying to use completionist mode (Baganator borrows the ATT setting when doing collected/uncollected searches)

commented

I don't -think- so? Screenshot of my main general settings below. I thought that it was actually called completionist mode but I'm not finding that.

2 notes:

  • I have a migraine pounding today so I may be missing something obvious
  • I have no particular love for my ATT settings so am willing to blow away the saved vars for it if that helps, but not doing until I hear back so I don't mess up repro.

wow att baganator 1

commented

I'm hoping this is fixed in the latest Syndicator release. Can you try it and see if its still broken?

commented

Ok, so it hasn't fixed the issue;

commented

Which version should fix the issue? I'm on 408 as per updating on Curse (via WowUp) this morning. If that's the version that should fix it, TLDR: no, sorry.

Details below are assuming 408 was supposed to be the fix. If there's a new version in the pipeline disregard the following and I'll retest when the correct version shows up for me.


Unfortunately I don't think it is.

How I'm testing:

  • Between tests I drag the 4 items in my Warband Bank into the manual 'Debug Collection' category so I don't accidentally do stuff with them.
  • For tests I remove these 4 items from 'Debug Collection' so they are sorted into categories.
  • If an item is 'Uncollected' it should go into the 'Uncollected' category with Highest priority
  • Otherwise it sorts into one of the other categories with lower priorities

Results:

The 4 test items all sorted into my 'Auction' category.

In case wanted, this is my current Baganator config export:

{"categories":[{"name":"Charms","search":"Pet Charm"},{"name":"Lockbox","search":"Lockbox"},{"name":"Debug Collection","search":""},{"name":"Shirts/Tabards","search":"#shirt | #tabard"},{"name":"Warbound","search":"#boa | #warbound"},{"name":"Tradeable","search":"tradeable"},{"name":"Rep","search":"reputation with"},{"name":"Vendor","search":"#gear"},{"name":" ","search":"#gear & soulbound & >490"},{"name":"Consumable","search":"battle pet | companion pet"},{"name":"Buffs (assign)","search":""},{"name":"Pets","search":"#battle pet"},{"name":"gear","search":"#gear"},{"name":"Training","search":"Battle-Training Stone | Battle-Stone"},{"name":"Uncollected","search":"uncollected & !soulbound"},{"name":"Auction?","search":"#boe"}],"version":1,"order":["_Sort Me","default_special_empty","Warbound","Uncollected","Tradeable","Auction?","Vendor","default_junk","Debug Collection","__end","_Quests/Rep/Key","default_questitem","Rep","default_key","__end","_My Gear","default_auto_equipment_sets"," ","Shirts/Tabards","__end","_Consume/Buff","Buffs (assign)","default_potion","default_food","default_consumable","default_itemenhancement","default_gem","__end","_Misc","default_container","default_toy","default_miscellaneous","Lockbox","__end","_Crafting","default_recipe","default_tradegoods","default_profession","default_reagent","__end","_Battle Pets","Pets","Training","Charms","Consumable","__end","default_other"],"modifications":[{"source":"Training","group":"type","priority":0},{"source":"default_armor"},{"source":"Tradeable","group":"quality","priority":2},{"source":"Vendor","priority":-1},{"source":"Pets","group":"type","priority":2},{"source":"default_weapon"},{"source":"gear","priority":3},{"source":"default_battlepet","group":"type"},{"items":[200443],"source":"Uncollected","priority":3},{"items":[210134,210083,198330,198328],"source":"Debug Collection","priority":-1},{"source":"default_food","group":"expansion"},{"source":"default_reagent","group":"expansion"},{"source":"default_auto_inventory_slots","group":"type"},{"source":"Shirts/Tabards","priority":0},{"source":"Warbound","group":"quality","priority":-1},{"source":"default_consumable"},{"source":"Rep","group":"expansion","priority":0},{"items":[211495,194823,191944],"source":"Buffs (assign)","group":"type","priority":0},{"source":" ","group":"slot","priority":2},{"source":"Consumable","priority":0},{"items":[6530],"source":"default_junk"},{"source":"default_auto_equipment_sets","priority":3},{"source":"default_potion","group":"type"},{"source":"Charms","priority":1},{"source":"Lockbox","group":"expansion","priority":0},{"source":"Auction?","priority":-1}],"hidden":[]}

And this is a screenshot of the test today:
baganator bug uncollected

commented

408 would be your version of Baganator. What version of Syndicator are you on?

commented

408 would be your version of Baganator. What version of Syndicator are you on?

93

commented

Roger, will retest whenever :) Thanks for the attention.

commented

I've released a new alpha using another Blizzard function. Can you test if this fixes the issue? https://www.curseforge.com/wow/addons/baganator/files/5603105

commented

Installed Baganator 409 from Alpha channel and have Syndicator 94.

  • Using same test parameters as I laid out earlier
    • Did a reload after removing from manual category just in case it needed a refresh.
    • Did a full exit and login to see if that helped.
  • Still no changes. Sorts the items removed from the manually assigned category to 'Auction' instead of 'Uncollected'.

If there's anything I might have bad in my config, let me know, but think it is valid.

PS. I set Baganator and Syndicator both to Alpha channel to see updates quicker.

commented

I finally got an item in my inventory that wasn't categorised correctly, and have now fixed the issue. 🥳

Syndicator-94-1-gc3dbf7a.zip

commented

Almost :|

I had 4 BoE (all test items are BoE) items that were affected:

  • Deadline Deadeyes ilvl 319 (DF crafted)
  • Quality-Assured Optics ilvl 319 (DF crafted)
  • Wakening Horror Spaulders ilvl 245 (Tomb of Sargeras)
  • Wind Wolf Shroud ilvl 421 (DF Season -3- ie, not current patch)

Additionally I found a 2 more in my bags after logging an alt that had some stuff:

  • Wind Wolf Legguards ilvl 418 (DF Season 3)
  • Maple Tender Robe ilvl 421 (DF Season 3)

The first 3 above sorted into 'Uncollected' YAY!

'Wind Wolf Shroud', 'Wind Wolf Legguards', 'Maple Tender Robe' still sorted into 'Auction?' boo.

Keeping all items to test with and putting back in the manually assigned category for now.

commented

Can you screenshot the items tooltips for the 3 that are still affected?

commented

Sure.

  • Dragged all items out of manual assigned category
  • Categories alone
    1  warband categories
  • Wind Wolf Shroud
    2  Wind Wolf Shroud
  • Maple Tender Robe
    3  Maple Tender Robe
  • Wind Wolf Legguards
    4  Wind Wolf Legguards

(ignore odd colors, used Windows snipping tool, doesn't behave well combined with Auto HDR)

I started a new alt for some UI dev time so I'll keep an eye out for any others if they pop up.

commented

Got a new release that fixes "Maple Tender Robe". I'm hoping this also fixes the other items.

Syndicator-95-1-gac0bbad.zip

commented

Just installed the .zip and ... boom ... all items show as 'Uncollected' now.

commented

So issue fixed?

commented

Yep. Thank you :)

I'll keep a few in bank to keep checking for awhile, just in case Blizz does more weirdness, but you can close. I'll re-open if I see it come up again :)

commented

Awesome. Thanks for your patience.