Baganator

Baganator

1M Downloads

Constant Errors when Casting Spells (Macros) or using Skyward Ascent

jeansteffano opened this issue · 27 comments

commented

The title speaks for itself, I love the addon but it's been bugging so much that I can't reliably play the game while it's enabled.

Issue:
Baganator is constantly activating the "Reload UI" screen issue when doing simple things as keypressing. It's most notably been showing this behaviour when involving Dragonriding or Macros.

Here's a full error report from Narcissus:

Blocked Action: UseAction()  Baganator (417)

Date: Tue Aug 13 07:20:22 2024
OS: Windows
Region: 1 (US)
Locale: enUS
Build Info: 11.0.0 (56008)  Aug  5 2024  (TOC Version 110000)  Public Build
Character: Level 69 Highmountain Tauren (28) Subtlety Rogue
Location: Dustwallow Marsh (70), Wyrmbog

Loaded AddOns:
DBM-Core (11.0.2)
DBM-StatusBarTimers (11.0.2)
DBM-VPVEM (eeae112)
ACP (3.5.12)
AddonFactory (11.0.001)
AstralKeys (4.10)
Auctionator (11.0.1)
Baganator (417)
Baganator-Simple (2)
BetterFishing (1.1.25)
BetterWardrobe (5.0.9)
CanIMogIt (11.0.0v2.2)
DataStore (2024.07.28)
DataStore_Achievements (2024.07.28)
DataStore_Agenda (2024.07.28)
DataStore_Auctions (2024.07.28)
DataStore_Characters (2024.07.28)
DataStore_Containers (2024.07.28)
DataStore_Crafts (2024.07.28)
DataStore_Currencies (2024.07.28)
DataStore_Garrisons (2024.07.28)
DataStore_Inventory (2024.07.28)
DataStore_Mails (2024.07.28)
DataStore_Pets (2024.07.28)
DataStore_Quests (2024.07.28)
DataStore_Reputations (2024.07.28)
DataStore_Spells (2024.07.28)
DataStore_Stats (2024.07.28)
DataStore_Talents (2024.07.28)
DeModal (0.8.1)
Details (#Details.12829.159)
Details_Compare2
Details_EncounterDetails
Details_RaidCheck
Details_Streamer
Details_TinyThreat
Details_Vanguard
DialogueUI (0.3.8)
DragonRider (0.4.0)
EasyDisenchantRevamped (1.0.0)
Farmer (3.25)
GatherMate2 (1.49.1)
idTip (11.5.0)
Leatrix_Maps (11.0.03)
Leatrix_Plus (11.0.03)
ManuscriptsJournal (11.0-001)
Narcissus (1.6.7)
Narcissus_BagFilter (1.0.2)
NoLootExperience (1.0.1)
Oilvl (11.0.3)
Plumber (1.3.3)
Postal (v4.1.8)
PremadeRegions (2.0.12)
RaiderIO_DB_US_M (10.2.7 (v202408130600))
RaiderIO (10.2.7 (v202408130600))
RaiderIO_DB_US_R (10.2.7 (v202408130600))
RaiderIO_DB_US_F (10.2.7 (v202408130600))
RemixMailHelper (2.2)
SharedMedia (3.1.2-200)
SharedMedia_MyMedia
SpeedyAutoLoot (2.2.21)
Syndicator (98)
TrueStatValues (1.0.0)
UnlimitedMapPinDistance (1.4.2)
WeakAuras (5.15.4)
WeakAurasArchive (5.15.4)
commented

@plusmouse managed to get the error and the taintlog, it's less ocurring, but it's normally related to Dragonriding and form switching, the main problem is that it may happen anywhere, including M+ scenarios (it's always happening on a keypress/UI interaction)

Last time it happened while opening a Chest in a Heroic Dungeon while in Travel Form, and again while trying to use Skyward Ascent after switching to Travel Form

8/19 04:29:23.155 Global variable ON_BAR_HIGHLIGHT_MARKS tainted by Baganator - Interface/AddOns/Blizzard_ActionBar/Mainline/ActionButton.lua:58 ClearOnBarHighlightMarks()
8/19 04:29:23.155 Interface/AddOns/Blizzard_PlayerSpells/ClassTalents/Blizzard_ClassTalentButtonTemplates.lua:43 Button:HideActionBarHighlights()
8/19 04:29:23.155 Interface/AddOns/Blizzard_PlayerSpells/ClassTalents/Blizzard_ClassTalentButtonTemplates.lua:213
8/19 04:29:23.155 PlayerSpellsFrame:Hide()
8/19 04:29:23.155 Interface/AddOns/Blizzard_UIParentPanelManager/Mainline/UIParentPanelManager.lua:1074
8/19 04:29:23.155 securecall()
8/19 04:29:23.155 Interface/AddOns/Blizzard_UIParentPanelManager/Mainline/UIParentPanelManager.lua:1115
8/19 04:29:23.155 CloseWindows()
8/19 04:29:23.155 Interface/AddOns/Blizzard_UIParentPanelManager/Mainline/UIParentPanelManager.lua:1129
8/19 04:29:23.155 securecall()
8/19 04:29:23.155 Interface/AddOns/Blizzard_UIParent/Mainline/UIParent.lua:2853
8/19 04:29:23.155 ToggleGameMenu()
8/19 04:29:23.155 TOGGLEGAMEMENU:1
8/19 04:29:23.155 Execution tainted by Baganator while reading ON_BAR_HIGHLIGHT_MARKS - Interface/AddOns/Blizzard_ActionBar/Mainline/ActionButton.lua:62 GetOnBarHighlightMark()
8/19 04:29:23.155 Interface/AddOns/Blizzard_ActionBar/Mainline/ActionButton.lua:626 ActionButton12:UpdateSpellHighlightMark()
8/19 04:29:23.155 Interface/AddOns/Blizzard_ActionBar/Mainline/ActionButton.lua:534 ActionButton12:Update()
8/19 04:29:23.155 Interface/AddOns/Blizzard_ActionBar/Mainline/ActionButton.lua:506 ActionButton12:UpdateAction()
8/19 04:29:23.155 Interface/AddOns/Blizzard_ActionBarController/Mainline/ActionBarController.lua:168 ActionBarController_UpdateAll()
8/19 04:29:23.155 Interface/AddOns/Blizzard_ActionBarController/Mainline/ActionBarController.lua:66
8/19 04:29:23.155 Interface/AddOns/Blizzard_ActionBar/Mainline/ActionButton.lua:1335 UpdateFlyout()
8/19 04:29:23.155 An action was blocked because of taint from Baganator - UseAction()
8/19 04:29:23.155 Interface/AddOns/Blizzard_FrameXML/Mainline/SecureTemplates.lua:342 handler()
8/19 04:29:23.155 Interface/AddOns/Blizzard_FrameXML/Mainline/SecureTemplates.lua:667 PerformAction()
8/19 04:29:23.155 Interface/AddOns/Blizzard_FrameXML/Mainline/SecureTemplates.lua:681 OnActionButtonClick()
8/19 04:29:23.155 Interface/AddOns/Blizzard_FrameXML/Mainline/SecureTemplates.lua:723 SecureActionButton_OnClick()
8/19 04:29:23.155 Interface/AddOns/Blizzard_ActionBar/Mainline/ActionButton.lua:100 TryUseActionButton()
8/19 04:29:23.155 Interface/AddOns/Blizzard_ActionBar/Mainline/ActionButton.lua:135 ActionButtonDown()
8/19 04:29:23.155 ACTIONBUTTON12:2

Below is how my Baganator is setup
image
image

commented

Thanks. I'm leveling a Druid to get flight form now.

commented

Try disabling Narcissus_BagFilter - a couple of other users reported doing this fixed their issues.

commented

If this doesn't fix the issue, run /console taintLog 1, wait for an error to happen, then upload your _retail_/Logs/taint.log file to here.

commented

will do! I'll let you know what I find out, thanks!

commented

Happened again after disabling Narcissus, will post the taint log soon!

commented

So, when it happened I enabled the taint log, but since then I've not seen any errors from Baganator, only from Narcissus. If anything shows up I'll let you know 😉

commented

I've released v424 that hopefully removes the only point of blocked action causes. If you don't experience any blocked actions after installing it in the next few days I'll close the issue. Do let me know if they happen again though.

commented

Do you use the single bag or categories mode?

commented

There's a fix for this particular taint issue in the latest alpha now. Please try that and report if you keep getting errors.

commented
commented

Happened again, same thing, now using Skyward Ascent with my monk.

Bug Grabber Log:

1x [ADDON_ACTION_FORBIDDEN] AddOn 'Baganator' tried to call the protected function 'UseAction()'.
[string "@!BugGrabber/BugGrabber.lua"]:485: in function <!BugGrabber/BugGrabber.lua:485>
[string "=[C]"]: in function `UseAction'
[string "@Blizzard_FrameXML/Mainline/SecureTemplates.lua"]:342: in function `handler'
[string "@Blizzard_FrameXML/Mainline/SecureTemplates.lua"]:667: in function <...ddOns/Blizzard_FrameXML/Mainline/SecureTemplates.lua:649>
[string "@Blizzard_FrameXML/Mainline/SecureTemplates.lua"]:681: in function <...ddOns/Blizzard_FrameXML/Mainline/SecureTemplates.lua:674>
[string "@Blizzard_FrameXML/Mainline/SecureTemplates.lua"]:723: in function `SecureActionButton_OnClick'
[string "@Blizzard_ActionBar/Mainline/ActionButton.lua"]:100: in function `TryUseActionButton'
[string "@Blizzard_ActionBar/Mainline/ActionButton.lua"]:135: in function `ActionButtonDown'
[string "ACTIONBUTTON2"]:2: in function <[string "ACTIONBUTTON2"]:1>

Locals:
_ = Frame {
}
event = "ADDON_ACTION_FORBIDDEN"
events = <table> {
}

image
image

commented

Hi. Sorry for the delay, but I've got another potential fix, you'll need to use the latest alphas for both Baganator and Syndicator to test this out:

Baganator-448-2-g970659e.zip

Syndicator-107-3-g53f67f4.zip

commented

Messed up the previous build. Use this one instead:
Baganator-450-2-gd9f8933.zip

commented

Hey! I've installed both files and will report if anything comes up! Thank you for your service 🫡

commented

Sadly it just happened again, Skyward Ascent, same thing. Now it's a different function though.

Please let me know if you need any more information!

image
image

2x [ADDON_ACTION_BLOCKED] AddOn 'Baganator' tried to call the protected function 'ActionButton1:SetAttribute()'.
[string "@!BugGrabber/BugGrabber.lua"]:485: in function <!BugGrabber/BugGrabber.lua:485>
[string "=[C]"]: in function `SetAttribute'
[string "@Blizzard_ActionBar/Mainline/ActionButton.lua"]:488: in function `UpdatePressAndHoldAction'
[string "@Blizzard_ActionBar/Mainline/ActionButton.lua"]:554: in function `Update'
[string "@Blizzard_ActionBar/Mainline/ActionButton.lua"]:506: in function `UpdateAction'
[string "@Blizzard_ActionBar/Mainline/ActionButton.lua"]:991: in function `OnEvent'
[string "@Blizzard_ActionBar/Mainline/ActionButton.lua"]:207: in function <Blizzard_ActionBar/Mainline/ActionButton.lua:204>

Locals:
_ = Frame {
}
event = "ADDON_ACTION_BLOCKED"
events = <table> {
}

commented

Thanks for the update.

commented

New build. I'm not very hopeful it'll fix anything, but it might.

Baganator-450-1-gd0f8df8.zip

Do note that items darkening because of being at a scrapper/recrafting/etc won't work in this build.

commented

On a second note, I just got the old error but it did not block me from using my skills:


3x [ADDON_ACTION_BLOCKED] AddOn 'Baganator' tried to call the protected function 'ActionButton1:SetAttribute()'.
[string "@!BugGrabber/BugGrabber.lua"]:485: in function <!BugGrabber/BugGrabber.lua:485>
[string "=[C]"]: in function `SetAttribute'
[string "@Blizzard_ActionBar/Mainline/ActionButton.lua"]:488: in function `UpdatePressAndHoldAction'
[string "@Blizzard_ActionBar/Mainline/ActionButton.lua"]:554: in function `Update'
[string "@Blizzard_ActionBar/Mainline/ActionButton.lua"]:506: in function `UpdateAction'
[string "@Blizzard_ActionBar/Mainline/ActionButton.lua"]:991: in function `OnEvent'
[string "@Blizzard_ActionBar/Mainline/ActionButton.lua"]:207: in function <Blizzard_ActionBar/Mainline/ActionButton.lua:204>

Locals:
_ = Frame {
}
event = "ADDON_ACTION_BLOCKED"
events = <table> {
}

commented

Ok! Testing!

commented

Yeah nope 🥲

1x [ADDON_ACTION_BLOCKED] AddOn 'Baganator' tried to call the protected function 'ActionButton9:SetAttribute()'.
[string "@!BugGrabber/BugGrabber.lua"]:485: in function <!BugGrabber/BugGrabber.lua:485>
[string "=[C]"]: in function `SetAttribute'
[string "@Blizzard_ActionBar/Mainline/ActionButton.lua"]:488: in function `UpdatePressAndHoldAction'
[string "@Blizzard_ActionBar/Mainline/ActionButton.lua"]:554: in function `Update'
[string "@Blizzard_ActionBar/Mainline/ActionButton.lua"]:506: in function `UpdateAction'
[string "@Blizzard_ActionBar/Mainline/ActionButton.lua"]:1466: in function <Blizzard_ActionBar/Mainline/ActionButton.lua:1463>
[string "=[C]"]: ?

Locals:
_ = Frame {
}
event = "ADDON_ACTION_BLOCKED"
events = <table> {
}

commented

Do you remember any UIs opened (map/bags/talent window)/level ups that happened during the session before the blocked action triggers?

commented

Honestly no UI is ever open. It happens randomly either in or out of combat while trying to press my "E" keybind (which is generally mapped for a macro or Skyward Ascent, when I'm mounted).

Here's my macro, for reference:

#showtooltip
/castsequence Keg Smash, Breath of Fire
/cast Purifying Brew

Here's my full list of addons (I've disabled Baganator for now):

image
image
image
image

commented

I have same problem, it happens when I cast spells with my druid. Nothing works until I disable addon itself and that is a shame because it's my favourite addon.

commented

For now using something like Bartender4 will work around the problem. Its unique to Blizzard action bars, and a new bug with 11.0.

commented

We've found the cause, DeModal (or any addon that interferes with default Blizzard frames closing) will cause the Baganator taint. If you remove that the taint should disappear.

commented

NoAutoClose will be patched soon to fix the taint, and does the same thing as DeModal.