Baganator

Baganator

Addons
1M Downloads

Add option to disable new item glow

KyrosKrane opened this issue ยท 3 comments

commented

What version(s) of WoW are you using?

Retail

What problem are you experiencing that led to you asking for this feature?

When new items are dropped into your bag, the game by default will cause those items to glow. I personally find this glow irritating and distracting. I would like for Baganator to have an option to disable that.

What solution would you like?

  1. Add a new option in Baganator options to disable new item glow. Mockup:
    image

  2. Modify ItemViewCommon/ItemButton.lua, in function ApplyNewItemAnimation(), around line 370. That line sets isNewItem based on a lookup. Instead, it should be something like the pseudocode below. (I'm not sure how to actually access Baganator options, so I faked it. :D )

local isNewItem
if Baganator.Options.DisableNewItemGlow then
    isNewItem = false
else
    isNewItem = addonTable.NewItems:IsNewItem(self:GetParent():GetID(), self:GetID());
end

Any alternatives you can think of?

No response

Anything else?

I tested the code in retail by simply adding isNewItem = false after line 370, and it appeared to work fine. I didn't get any lua errors in a few days of playing, and items behaved normally. I didn't test this in Classic or Cata.

commented

Would also love this, or at least an option to turn off the flashing...

commented

I would like this option too. I've requested it here before but the author said they have no plans to do it. Hopefully they might be swayed with your more in depth request and if enough people are interested in having it.