Conditions for displaying the guild inventory are not so useful
tflo opened this issue · 4 comments
I was wondering why the guild bank inventory display only worked on my guild master toon, but not on the others, until I found the ["fullAccess"]
keys in the database.
This key is set in GuildCache.lua , with…
tab.fullAccess = (numWithdrawals == -1 or numWithdrawals >= Baganator.Constants.GuildBankFullAccessWithdrawalsLimit)
(The constant is set to 25000.)
If I'm not mistaken, this actually disables the guild bank tooltip for all toons, except…
- The guild master toon (-1)
- Any toon that has a withdrawal limit of 25000 or more for the tab
Assuming this is intentional, I think these conditions are not very useful:
- 25000 seems to be an arbitrary value, the hard limit in my tests was 100000. So, why 25000?
- Even if a toon can only withdraw 1 unit, the guild bank display is still useful.
- It is even useful for a toon that cannot withdraw at all, because I can always switch to a withdrawing (higher rank) toon if available.
- It is also useful for depositing stuff: Before you go to the guild bank to deposit some healing potions, it would be nice to see if there are already 50 stacks of them hoarded :)
Basically, the idea to display only stuff that is actually available is nice. But for that, probably a thing like…
tab.fullAccess = remainingWithdrawals >= 1
…seems more useful (on paper, assuming the API returns the correct numbers).
But as said, the tooltip info can even be useful for depositing things – or just out of curiosity –, so I would skip the limitations altogether (or per user setting).
The check was intentional and to avoid showing guild bank info for those which a player might not have access to.
I'll change it to an option of "Show guild banks in tooltips" which should resolve this issue.
Aside
There is WIP version of Baganator that shows guild bank contents in a limited Baganator UI:
Its incomplete and doesn't hide the Blizzard UI at all.
The check was intentional and to avoid showing guild bank info for those which a player might not have access to.
I'll change it to an option of "Show guild banks in tooltips" which should resolve this issue.
[emphasis mine]
I am not sure you understand my point. The option should make the display of the guild bank inventory truly unconditional (ignoring arbitrary restrictions such as the withdrawal limit), like tab.fullAccess = true
.
A second option to hide/show the guild bank inventory entirely would be OK, but is not really related to this.
I tried your linked guild view build (0.118-14-g53895d3), and it looks really promising 🙂
One thing I noticed was that on an Alliance toon that has never opened the guild bank himself since install of Baganator (though the Alliance guild bank has been opened multiple times on other toons in the same guild/realm/account), the frame showed the guild bank of my Hordies.
Opening the guild bank on the toon, followed by a reload, fixed the issue.1
I double-checked it on toons that had opened the guild banks themselves before, and there it showed the correct guild from the beginning.
The tabs at the bottom are exceeding the frame width, but I guess you know that. Maybe better to make them vertical tabs:
Edit: added footnote concerning the wrong guild display
Footnotes
More Aside
The guild bank view now has the mentioned issues resolved:
Baganator-0.120-18-g87fb241.zip